[Feature] Post Titles :) #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added title field to status - Redux actions for setting title, piggybacking off spoilers - Dont allow titles in replies - Add messages to i18n - Validation of title length
…and the main external url pattern recognizes the slugs, but there's some kind of problem where after the page is initially loaded the react uses the ID from the URL to make context/etc. requests rather than ID from like the correctly returned API request
…just so we have some place to return. Added slugs_controller.rb because we'll need it eventually anyway. Tried to make it so all the slug and ID confusion gets resolved on one request pass through the thing, and then afterwards slugs work the same as post ids. (assuming the same slug isn't in the same thread which would probably be a problem)
… the interface, copy to clipboard, etc. :)
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i will write a longer description later but rn jonny is very hungy.
anyway it's this:
post_titles_blur.mp4
Motivation:
One step towards:
https://wiki.neuromatch.social/Sticky_Posts
To have a better way of communicating in-medium about proposals and instance governance stuff since announcements are effectively invisible and you can't discuss things underneath them anyway. It would be lovely to have sticky posts in home and local feeds. To make that not horrible we need to be able to collapse them down really tiny so they aren't obtrusive. To make that work we need to have something to show when they're collapsed, and a title sounds like a good idea.
Additionally, if posts have titles and you can shrink them down very tiny, then we can also get something like a forum where the post title serves as a "thread" within the "category" of the title.
Additionally Additionally we can make another tab drawer on someone's account that serves more as a longform blog, with all their titled posts
Summary:
slugandtitleare separate fields fromtextin the REST serialization,contentis the rendered HTML, as masto usually does./accounts/:username/slugs/:slugendpoint to get a single status by slugheadmetadataTODO:
Another PR
slugsAPI endpoint an index so we can use it to make a separate page