Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style bigger collapse #29

Closed
wants to merge 3,299 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
3299 commits
Select commit Hold shift + click to select a range
4e6db5e
chore(deps): update yarn to v4.3.1 (#30790)
renovate[bot] Jun 21, 2024
2cab1c7
Improve encoding detection for link cards (#30780)
oneiros Jun 21, 2024
4651c0c
Fix `Rails/ReversibleMigrationMethodDefinition` cop (#30794)
mjankowski Jun 21, 2024
1090611
Merge pull request #2751 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jun 21, 2024
72484a1
Remove `CacheBuster` default options (#30718)
mjankowski Jun 21, 2024
348ccf2
Fix `Style/ClassEqualityComparison` cop (#30058)
mjankowski Jun 21, 2024
929b9fd
Remove exclusion for `Rails/LexicallyScopedActionFilter` cop (#30697)
mjankowski Jun 21, 2024
253a9f7
chore(deps): update dependency addressable to v2.8.7 (#30791)
renovate[bot] Jun 21, 2024
abbda3d
chore(deps): update dependency node to 20.15 (#30782)
renovate[bot] Jun 21, 2024
f898214
chore(deps): update opentelemetry-ruby (non-major) (#30771)
renovate[bot] Jun 21, 2024
8fd5b59
chore(deps): update dependency devise-two-factor to v5.1.0 (#30760)
renovate[bot] Jun 21, 2024
93741f6
fix(deps): update dependency glob to v10.4.2 (#30761)
renovate[bot] Jun 21, 2024
637de63
chore(deps): update dependency public_suffix to v6 (#30738)
renovate[bot] Jun 21, 2024
4743657
Fix Docker buildx warnings about casing and undefined variables (#30798)
vmstan Jun 21, 2024
3b46079
Merge commit '4743657ba24e83c376e9f477fbf49114e6f09a57' into glitch-s…
ClearlyClaire Jun 22, 2024
be3d60c
Merge pull request #2753 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jun 23, 2024
3f81e7d
chore(deps): update dependency @types/http-link-header to v1.0.6 (#30…
renovate[bot] Jun 24, 2024
6d14cfb
Unset Rails/UnusedIgnoredColumns (#30800)
nschonni Jun 24, 2024
b371009
chore(deps): update dependency opentelemetry-instrumentation-faraday …
renovate[bot] Jun 24, 2024
54cc204
Use WebSocketServer instead of WebSocket.Server in streaming (#30788)
TheEssem Jun 24, 2024
1af6313
Fix CMD syntax in streaming Dockerfile (#30795)
TheEssem Jun 24, 2024
61722b1
New Crowdin Translations (automated) (#30808)
github-actions[bot] Jun 24, 2024
8827cd5
Fix `/admin/accounts/:account_id/statuses/:id` for edited posts with …
ClearlyClaire Jun 24, 2024
f6e4660
Added check for STATSD_ADDR setting to emit a warning and proceed rat…
timothyjrogers Jun 24, 2024
39d80e8
Remove `lockfileMaintenance` setting (#30799)
mjankowski Jun 24, 2024
6527d50
Disable `Rails/BulkChangeTable` cop (#30820)
mjankowski Jun 24, 2024
21ca035
Merge commit '6527d5039141fe4a80645147b581d76952a64f39' into glitch-s…
ClearlyClaire Jun 24, 2024
9aee910
Merge pull request #2754 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jun 24, 2024
025c09f
Merge pull request #51 from NeuromatchAcademy/robots.txt-update
sneakers-the-rat Jun 24, 2024
052c90b
New Crowdin Translations (automated) (#30825)
github-actions[bot] Jun 25, 2024
30ae595
Fix: Ensure "With Media" is highlighted from Admin Accounts page (#30…
ThisIsMissEm Jun 25, 2024
3092748
chore(deps): update dependency aws-sdk-s3 to v1.153.0 (#30824)
renovate[bot] Jun 25, 2024
547e979
Change `apiRequest` to accept both `params` and `data` (#30818)
renchap Jun 25, 2024
8ef5972
Ignore intermittent chrome/manifest/icon interaction failure (#30793)
mjankowski Jun 25, 2024
845fe1c
Add the Interlingua locale (#30828)
renchap Jun 25, 2024
6f2771c
Merge commit '845fe1c6936a7b386fd74ae567c19600a88e795a' into glitch-s…
ClearlyClaire Jun 25, 2024
3a20290
[Glitch] Change `apiRequest` to accept both `params` and `data`
renchap Jun 25, 2024
2c7eed1
Fix API requests after #30818 (#30837)
ClearlyClaire Jun 25, 2024
85e6efd
Merge commit '2c7eed1fa1e7af72dd03a041a60f2cfd42e913e0' into glitch-s…
ClearlyClaire Jun 25, 2024
7d89d1f
[Glitch] Fix API requests after #30818
ClearlyClaire Jun 25, 2024
07d2226
chore(deps): update dependency typescript to v5.5.2 (#30815)
renovate[bot] Jun 25, 2024
1eb69c5
Merge pull request #2758 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jun 25, 2024
a40831b
Fix account search results (#30803)
Gargron Jun 25, 2024
8c0ff64
Change light mode to apply CSS variables to the body (#30839)
renchap Jun 25, 2024
2b43c05
chore(deps): update dependency aws-sdk-s3 to v1.154.0 (#30838)
renovate[bot] Jun 26, 2024
7a84b76
Drop favicon.ico generation (#30375)
ClearlyClaire Jun 26, 2024
528a7f5
Fix `Rails/ReversibleMigration` cop for `change_column` (#30835)
mjankowski Jun 26, 2024
51f581e
Fix `Rails/ReversibleMigration` cop for `remove` (#30833)
mjankowski Jun 26, 2024
863c470
Convert `<Directory>` to Typescript / function component (#30829)
renchap Jun 26, 2024
e89317d
Add hover cards in web UI (#30754)
Gargron Jun 26, 2024
3939352
Convert `<ColumnHeader>` to Typescript (#30849)
Gargron Jun 26, 2024
ad53b0a
Rely on built-in ruby private IP detection (#30848)
mjankowski Jun 27, 2024
f6390c3
Use flatware to parallelize CI specs (#30284)
mjankowski Jun 27, 2024
6d1c1fd
New Crowdin Translations (automated) (#30851)
github-actions[bot] Jun 27, 2024
096057b
Change `author_account` to be `authors` in REST API (#30846)
Gargron Jun 27, 2024
42adb6e
Add size limit for link preview URLs (#30854)
oneiros Jun 27, 2024
ff08d99
Catch encoding errors when creating link previews. (#30853)
oneiros Jun 27, 2024
b15a361
Stub `Vips::Error` when not using libvips (#30857)
ClearlyClaire Jun 27, 2024
836c047
Use vips setting instead of env var in media processing spec (#30859)
mjankowski Jun 27, 2024
03bbb74
fix(deps): update dependency prom-client to v15.1.3 (#30852)
renovate[bot] Jun 27, 2024
bc3737f
Add detail about running version on vips error failure (#30858)
mjankowski Jun 27, 2024
3225954
Fix browser window color on light theme (#30861)
vmstan Jun 27, 2024
0f3fef6
Change search modifiers to be case-insensitive (#30865)
Gargron Jun 27, 2024
ea6c455
Fix follow button in hover cards not working when signed out in web U…
Gargron Jun 27, 2024
a5134f2
New Crowdin Translations (automated) (#30867)
github-actions[bot] Jun 28, 2024
1bccba1
chore(deps): update dependency @testing-library/react to v16 (#30533)
renovate[bot] Jun 28, 2024
ba6a558
Simplify color extraction code using `bandunfold` (#30869)
ClearlyClaire Jun 28, 2024
5d4dbbc
chore(deps): update dependency charlock_holmes to v0.7.8 (#30870)
renovate[bot] Jun 29, 2024
d2aea85
Merge commit '5d4dbbcc67c98007d417cbe67b5a2261889304dc' into glitch-s…
ClearlyClaire Jun 30, 2024
1ac4e64
[Glitch] Change light mode to apply CSS variables to the body
renchap Jun 25, 2024
8160a65
[Glitch] Convert `<Directory>` to Typescript / function component
renchap Jun 26, 2024
d612dae
[Glitch] Convert `<ColumnHeader>` to Typescript
Gargron Jun 26, 2024
4179f5f
[Glitch] Change `author_account` to be `authors` in REST API
Gargron Jun 27, 2024
9818524
[Glitch] Add hover cards in web UI
Gargron Jun 26, 2024
412e5dd
[Glitch] Fix follow button in hover cards not working when signed out…
Gargron Jun 27, 2024
935b955
Temporarily disable hover cards
ClearlyClaire Jun 30, 2024
a396985
Merge pull request #2760 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jun 30, 2024
6d6064d
fix(collapsing): fix and simplify post collapsing CSS (#2757)
ariasuni Jun 30, 2024
8142c7a
chore(deps): update definitelytyped types (non-major) (#30882)
renovate[bot] Jul 1, 2024
9c7d56d
fix(deps): update dependency postcss-preset-env to v9.5.15 (#30878)
renovate[bot] Jul 1, 2024
3c1e168
fix(deps): update dependency postcss to v8.4.39 (#30877)
renovate[bot] Jul 1, 2024
2f1df84
chore(deps): update dependency test-prof to v1.3.3.1 (#30872)
renovate[bot] Jul 1, 2024
4c70146
chore(deps): update dependency aws-sdk-s3 to v1.155.0 (#30871)
renovate[bot] Jul 1, 2024
ed15ae0
fix(deps): update dependency @reduxjs/toolkit to v2.2.6 (#30875)
renovate[bot] Jul 1, 2024
7756db6
New Crowdin Translations (automated) (#30873)
github-actions[bot] Jul 1, 2024
aefb4c0
chore(deps): update dependency rubocop-rails to v2.25.1 (#30876)
renovate[bot] Jul 1, 2024
aeefe5b
chore(deps): update eslint (non-major) (#30883)
renovate[bot] Jul 1, 2024
d270165
Merge commit 'aeefe5b2bea6e0fb511f029c2aacdefa7bd41eb8' into glitch-s…
ClearlyClaire Jul 1, 2024
20fa9ce
Add timeline of public posts about a trending link in web UI (#30840)
Gargron Jul 1, 2024
b728c0e
Change hover cards to not appear until the mouse stops in web UI (#30…
Gargron Jul 1, 2024
d3f5042
Fix missing confirmation when unfollowing from hover card in web UI (…
Gargron Jul 1, 2024
92dcc50
Merge commit 'd3f504245cab5a9a0e89262e0a1398d035dffac9' into glitch-s…
ClearlyClaire Jul 1, 2024
dcfd399
[Glitch] Change hover cards to not appear until the mouse stops in we…
Gargron Jul 1, 2024
a70b114
[Glitch] Fix missing confirmation when unfollowing from hover card in…
Gargron Jul 1, 2024
4c5067e
[Glitch] Add timeline of public posts about a trending link in web UI
Gargron Jul 1, 2024
4d4f7ed
Revert "Temporarily disable hover cards"
ClearlyClaire Jul 1, 2024
71375e9
Merge pull request #2761 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 1, 2024
1fc14e3
New Crowdin Translations (automated) (#30890)
github-actions[bot] Jul 2, 2024
ebd8e1b
Add system check for missing database indexes (#30888)
oneiros Jul 3, 2024
2e295bd
chore(deps): update dependency aws-sdk-s3 to v1.156.0 (#30899)
renovate[bot] Jul 3, 2024
ba7e7a6
chore(deps): update opentelemetry-ruby (non-major) (#30898)
renovate[bot] Jul 3, 2024
dd85e3b
New Crowdin Translations (automated) (#30901)
github-actions[bot] Jul 3, 2024
5651c16
Limit `browser` version to enforce ruby 3.1 support (#30766)
mjankowski Jul 3, 2024
1dbffc3
chore(deps): update opentelemetry-ruby (non-major) (#30903)
renovate[bot] Jul 3, 2024
6270281
chore(deps): update dependency doorkeeper to v5.7.1 (#30053)
renovate[bot] Jul 3, 2024
f99159d
fix(deps): update dependency webpack-merge to v6 (#30891)
renovate[bot] Jul 3, 2024
20c749b
chore(deps): update dependency rubocop-rspec to v3.0.2 (#30902)
renovate[bot] Jul 3, 2024
9be77fc
Revert "Add system check for missing database indexes" (#30909)
oneiros Jul 3, 2024
47f0fae
Implement HTML ruby tags for east-asian languages (#30897)
ThisIsMissEm Jul 3, 2024
70ff7a7
Merge commit '9be77fc0dbb01c1a8a54cd3da97e16c7941df367' into glitch-s…
ClearlyClaire Jul 3, 2024
58f027a
Merge pull request #2763 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 3, 2024
8331f9e
New Crowdin Translations (automated) (#30916)
github-actions[bot] Jul 4, 2024
528661a
fix(deps): update dependency pino-http to v10.2.0 (#30913)
renovate[bot] Jul 4, 2024
b730147
fix(deps): update dependency ws to v8.18.0 (#30914)
renovate[bot] Jul 4, 2024
395f17c
Merge pull request from GHSA-vp5r-5pgw-jwqx
ClearlyClaire Jul 4, 2024
502cf75
Merge pull request from GHSA-58x8-3qxw-6hm7
ClearlyClaire Jul 4, 2024
d3a056a
Merge pull request from GHSA-xjvf-fm67-4qc3
ClearlyClaire Jul 4, 2024
df9e261
Bump version to v4.3.0-alpha.5 (#30920)
ClearlyClaire Jul 4, 2024
e61a779
Merge commit 'df9e26158d9787859b24bdc276af478abf05e1af' into glitch-s…
ClearlyClaire Jul 4, 2024
05cfe04
Merge pull request #2765 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 4, 2024
8de5df2
Change instructions to use `bundle exec rails` instead of `rake` (#30…
ClearlyClaire Jul 5, 2024
8c375d8
Use `scope module: ...` for settings/2FA routes (#30919)
mjankowski Jul 5, 2024
8154784
New Crowdin Translations (automated) (#30925)
github-actions[bot] Jul 5, 2024
a16c2c9
fix(deps): update dependency cssnano to v7.0.4 (#30927)
renovate[bot] Jul 5, 2024
05f0d51
chore(deps): update dependency sidekiq-scheduler to v5.0.5 (#30918)
renovate[bot] Jul 5, 2024
45fed35
Merge branch 'glitch-soc-main' into merge-upstream
sneakers-the-rat Jul 5, 2024
bdea159
Merge branch 'main' into merge-upstream
sneakers-the-rat Jul 5, 2024
016c1e4
Improve handling of encoding problems when creating link previews (#3…
oneiros Jul 5, 2024
97eddb5
Fix details extraction when no title exists. (#30933)
oneiros Jul 5, 2024
8f5694d
Fix right-to-left text in preview cards (#30930)
ClearlyClaire Jul 5, 2024
63ba698
Fix overflow behavior on profile fields in hover cards (#30928)
ClearlyClaire Jul 6, 2024
11dd51e
Merge commit '63ba69810eca80fc2d10114a79f2988c1b75892f' into glitch-s…
ClearlyClaire Jul 6, 2024
aca1dec
[Glitch] Fix right-to-left text in preview cards
ClearlyClaire Jul 5, 2024
a99ae90
[Glitch] Fix overflow behavior on profile fields in hover cards
ClearlyClaire Jul 6, 2024
1d35626
Limit CI push triggers to `main` and `stable-*` branches (#30934)
mjankowski Jul 7, 2024
6976637
Merge pull request #2768 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 7, 2024
0899c91
Add the account hover card for account search results (#30949)
renchap Jul 7, 2024
981395e
Remove the `title` attribute when hovering a card anchor (#30948)
renchap Jul 7, 2024
c5883e0
chore(deps): update dependency @testing-library/dom to v10.3.1 (#30954)
renovate[bot] Jul 8, 2024
5c3ec72
chore(deps): update dependency typescript to v5.5.3 (#30953)
renovate[bot] Jul 8, 2024
bd84817
chore(deps): update dependency irb to v1.14.0 (#30947)
renovate[bot] Jul 8, 2024
bd285cd
fix(deps): update dependency glob to v10.4.3 (#30941)
renovate[bot] Jul 8, 2024
c29fdad
Use `scope module: ...` for more API routes (#30935)
mjankowski Jul 8, 2024
fd3bfc0
fix(deps): update dependency postcss-preset-env to v9.6.0 (#30944)
renovate[bot] Jul 8, 2024
d41b43e
Limit attachments to `MEDIA_ATTACHMENTS_LIMIT` when returning posts t…
ClearlyClaire Jul 8, 2024
1a37862
New Crowdin Translations (automated) (#30940)
github-actions[bot] Jul 8, 2024
36d819b
Change to use an unified constant for max media attachments per statu…
ileodo Jul 8, 2024
79b0e19
Move test migrations paths check to workflow level (#30702)
mjankowski Jul 8, 2024
f1300ad
Rename jobs/attachments rspec tag names (#29762)
mjankowski Jul 8, 2024
fa8e972
Fix author names as arrays in linked data. (#30957)
oneiros Jul 8, 2024
6a55232
Merge commit 'fa8e972722fb8fc056aa348dddaee4005b4a8ac4' into glitch-s…
ClearlyClaire Jul 8, 2024
2fa3c3a
[Glitch] Add the account hover card for account search results
renchap Jul 7, 2024
aa8ad92
[Glitch] Remove the `title` attribute when hovering a card anchor
renchap Jul 7, 2024
80179d5
[Glitch] Change to use an unified constant for max media attachments …
ileodo Jul 8, 2024
3e47d01
Merge pull request #2770 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 8, 2024
0dd4595
fix(deps): update dependency glob to v10.4.4 (#30967)
renovate[bot] Jul 9, 2024
7a30c68
Use `scope module: ...` block for `.well-known` routes (#30959)
mjankowski Jul 9, 2024
f47d761
Remove unneeded `controller` option in routes (#30958)
mjankowski Jul 9, 2024
249b411
New Crowdin Translations (automated) (#30970)
github-actions[bot] Jul 9, 2024
7542a13
Add a file for Sidekiq to signal it is ready to process jobs (#30971)
renchap Jul 9, 2024
3875bd1
Fix HTTP 500 in `/api/v1/polls/:id/votes` (#25598)
danielmbrasil Jul 9, 2024
ef2e48e
fix(deps): update dependency glob to v10.4.5 (#30972)
renovate[bot] Jul 9, 2024
967505e
Add size limit for all PreviewCard URLs (#30973)
oneiros Jul 9, 2024
388672f
Merge commit '967505ee9bcacf0e5189aa06c654ff586c198a46' into glitch-s…
ClearlyClaire Jul 9, 2024
56e347d
Merge pull request #2771 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 9, 2024
c9f08f7
fix(deps): update dependency sass to v1.77.7 (#30981)
renovate[bot] Jul 10, 2024
d013791
chore(deps): update dependency ruby to v3.3.4 (#30969)
renovate[bot] Jul 10, 2024
8dea897
chore(deps): update docker.io/ruby docker tag to v3.3.4 (#30980)
renovate[bot] Jul 10, 2024
9984fca
New Crowdin Translations (automated) (#30983)
github-actions[bot] Jul 10, 2024
182b924
Fix SCSS mixed declarations deprecation (#30986)
renchap Jul 10, 2024
36592d1
Change Sidekiq readiness file to use an environment variable (#30988)
renchap Jul 10, 2024
2ea9336
Do not pass unknown encoding names to nokogiri. (#30987)
oneiros Jul 10, 2024
52fb4f1
Merge commit '2ea9336b6855b44126a55106a81e96ea68eaf8ff' into glitch-s…
ClearlyClaire Jul 10, 2024
0d4a8a5
[Glitch] Fix SCSS mixed declarations deprecation
renchap Jul 10, 2024
959ad1d
Fix deprecation warning in win95 theme
ClearlyClaire Jul 10, 2024
d436696
Streaming: Fix incorrect type definitions (#30977)
ThisIsMissEm Jul 10, 2024
5c9c024
Merge pull request #2772 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 10, 2024
182fee1
New Crowdin Translations (automated) (#2738)
github-actions[bot] Jul 10, 2024
631a5ee
chore(deps): update dependency charlock_holmes to v0.7.9 (#30992)
renovate[bot] Jul 10, 2024
24bdba3
chore(deps): update dependency rubocop to v1.65.0 (#30985)
renovate[bot] Jul 11, 2024
c244b70
New Crowdin Translations (automated) (#30993)
github-actions[bot] Jul 11, 2024
6c37529
Use `module: :auth` to wrap `devise_for` routes config (#30990)
mjankowski Jul 11, 2024
8c8bee5
Change disabled buttons color in light mode to make it more visible (…
renchap Jul 11, 2024
db0b12e
Merge commit '8c8bee5a36e0cd0b5d35903f8891896447c3e060' into glitch-s…
ClearlyClaire Jul 11, 2024
e260521
[Glitch] Change disabled buttons color in light mode to make it more …
renchap Jul 11, 2024
ad52b04
Add setting to disable hover cards (#30931)
ClearlyClaire Jul 11, 2024
813f86d
Merge pull request #2774 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 11, 2024
bb702e6
fix(deps): update dependency sass to v1.77.8 (#31005)
renovate[bot] Jul 12, 2024
73d5382
Add change assertion to invites destroy spec (#31004)
mjankowski Jul 12, 2024
cd1bc94
Regen RuboCop TODO for 1.65.0 (#31003)
nschonni Jul 12, 2024
fdad4dc
fix(deps): update babel monorepo to v7.24.8 (#31002)
renovate[bot] Jul 12, 2024
28ad358
New Crowdin Translations (automated) (#31006)
github-actions[bot] Jul 12, 2024
43e24db
Use `include_pagination_headers` in more places (#30999)
mjankowski Jul 12, 2024
9cc0607
chore(deps): update dependency database_cleaner-active_record to v2.2…
renovate[bot] Jul 12, 2024
c929b4c
chore(deps): update dependency pghero to v3.6.0 (#30994)
renovate[bot] Jul 12, 2024
55cf5e0
Merge commit 'c929b4cace3f95fe54fdafe449ea7e972c8d61e8' into glitch-s…
ClearlyClaire Jul 12, 2024
8d2a93b
[Glitch] Add setting to disable hover cards
ClearlyClaire Jul 11, 2024
35a437a
Destroy `NotificationRequest`s that are dismissed (#31008)
oneiros Jul 12, 2024
b87c411
chore(deps): update dependency rubocop-rspec to v3.0.3 (#31009)
renovate[bot] Jul 12, 2024
c953dca
Streaming: use pgPool.query instead of manually acquiring & releasing…
ThisIsMissEm Jul 12, 2024
00cb4a0
Avoid repeated factory creation in media_attachments_vacuum_spec (#31…
mjankowski Jul 12, 2024
5464224
Merge pull request #2775 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 12, 2024
edec2e9
Merge commit '00cb4a0313190bfa118966692a649db9c8328094' into glitch-s…
ClearlyClaire Jul 14, 2024
d329eda
Merge pull request #2776 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 14, 2024
d61b536
Add i18n strings for instance favicon and logo settings label (#31016)
mgmn Jul 15, 2024
1711710
New Crowdin Translations (automated) (#31018)
github-actions[bot] Jul 15, 2024
1dd8262
Add optional `filtered` attribute to notification entities in REST AP…
ClearlyClaire Jul 15, 2024
91ef4a6
Add assertion about key columns to account key generate spec (#30635)
mjankowski Jul 15, 2024
543b59f
Clean up `theme_helper` style builders (#30617)
mjankowski Jul 15, 2024
0b97ec3
fix(deps): update dependency @babel/core to v7.24.9 (#31029)
renovate[bot] Jul 15, 2024
9d0bce4
Move filtered notifications bar in scrollable area (#30996)
oneiros Jul 15, 2024
64b2c71
Merge commit '9d0bce40724eb77b7cc3917091b62e4ab159e29e' into glitch-s…
ClearlyClaire Jul 15, 2024
70969ac
[Glitch] Move filtered notifications bar in scrollable area
oneiros Jul 15, 2024
b7b6f1c
Merge pull request #2777 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 15, 2024
905921b
Add missing "Update Report" string in audit log (#31033)
vmstan Jul 16, 2024
c3a2f9d
chore(deps): update dependency json-schema to v4.3.1 (#31012)
renovate[bot] Jul 16, 2024
c27d194
fix(deps): update dependency pino to v9.3.1 (#31032)
renovate[bot] Jul 16, 2024
fa54b61
Handle missing links in Webfinger response (#31030)
adamniedzielski Jul 16, 2024
aa88aca
Add optional OAuth application to reports (#30539)
ThisIsMissEm Jul 16, 2024
a609940
Fix test description in hashtag_bar (#30827)
adamniedzielski Jul 16, 2024
66430cb
New Crowdin Translations (automated) (#31038)
github-actions[bot] Jul 16, 2024
c546757
Merge commit '66430cb25c824cfad0394216d8e7a523533bcf4b' into glitch-s…
ClearlyClaire Jul 16, 2024
d6a2635
Merge pull request #2780 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 16, 2024
00c110a
New Crowdin Translations (automated) (#31047)
github-actions[bot] Jul 17, 2024
81877e7
Reduce extra round trips in `AP::FetchRemoteStatusService` spec (#31045)
mjankowski Jul 17, 2024
f5e90f3
Reduce extra round trips in `AP::SynchronizeFollowersService` spec (#…
mjankowski Jul 17, 2024
76c2c5c
Reduce extra round trips in `activitypub` controller specs (#31041)
mjankowski Jul 17, 2024
4957771
Update rexml to version 3.3.2 (#31048)
ClearlyClaire Jul 17, 2024
aa4d898
chore(deps): update dependency faker to v3.4.2 (#31046)
renovate[bot] Jul 17, 2024
5e7720d
Merge commit 'aa4d8987a00fe82490fb949b82d3baa33d0acd49' into glitch-s…
ClearlyClaire Jul 17, 2024
fb29f40
Merge pull request #2781 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 17, 2024
c5f8256
Reduce extra factories in `FanOutOnWriteService` spec (#31053)
mjankowski Jul 18, 2024
2616fde
Use change-requiring records in admin/reports controller spec (#31052)
mjankowski Jul 18, 2024
64c7ffd
chore(deps): update dependency ruby-vips to v2.2.2 (#31050)
renovate[bot] Jul 18, 2024
47ea83d
Reduce factory creation in `AP::ProcessStatusUpdateService` spec (#31…
mjankowski Jul 18, 2024
7d090b2
New Crowdin Translations (automated) (#31055)
github-actions[bot] Jul 18, 2024
f587ff6
Grouped Notifications UI (#30440)
renchap Jul 18, 2024
6e47637
Fix grouping across hourly buckets happening in a 12 seconds window i…
ClearlyClaire Jul 18, 2024
41b7281
fix(deps): update dependency use-debounce to v10.0.1 (#31060)
renovate[bot] Jul 18, 2024
848b59c
Reduce factory creation in `MediaAttachment` model spec (#31058)
mjankowski Jul 18, 2024
8234434
Add link to org-level contribution guidelines to contributing doc (#3…
mjankowski Jul 18, 2024
c75fe09
Merge commit '82344342c1c5adb3f6a4b376559db737a9e982b7' into glitch-s…
ClearlyClaire Jul 18, 2024
7224e24
[Glitch] Grouped Notifications UI
renchap Jul 18, 2024
d55ecf4
Merge pull request #2782 from ClearlyClaire/glitch-soc/merge-upstream
ClearlyClaire Jul 18, 2024
af24bf9
Merge branch 'glitch-soc-main' into merge-upstream
sneakers-the-rat Jul 19, 2024
8d8af90
mathjax: remove componentWillMount from latexdropdown
sneakers-the-rat Jul 19, 2024
c567ffb
Merge pull request #53 from NeuromatchAcademy/merge-upstream
sneakers-the-rat Jul 19, 2024
d37648f
merge main
sneakers-the-rat Jul 19, 2024
e1c717c
fix bigger status previews after grouped notifs update
sneakers-the-rat Jul 19, 2024
3c4e357
correct selectors for notifications, hover lightening
sneakers-the-rat Jul 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Destroy NotificationRequests that are dismissed (mastodon#31008)
oneiros authored Jul 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 35a437a03f4e1f606afea8953f0be62807da91cc
8 changes: 2 additions & 6 deletions app/controllers/api/v1/notifications/requests_controller.rb
Original file line number Diff line number Diff line change
@@ -28,14 +28,14 @@ def accept
end

def dismiss
@request.update!(dismissed: true)
@request.destroy!
render_empty
end

private

def load_requests
requests = NotificationRequest.where(account: current_account).where(dismissed: truthy_param?(:dismissed) || false).includes(:last_status, from_account: [:account_stat, :user]).to_a_paginated_by_id(
requests = NotificationRequest.where(account: current_account).includes(:last_status, from_account: [:account_stat, :user]).to_a_paginated_by_id(
limit_param(DEFAULT_ACCOUNTS_LIMIT),
params_slice(:max_id, :since_id, :min_id)
)
@@ -68,8 +68,4 @@ def pagination_max_id
def pagination_since_id
@requests.first.id
end

def pagination_params(core_params)
params.slice(:dismissed).permit(:dismissed).merge(core_params)
end
end
2 changes: 1 addition & 1 deletion app/models/notification_policy.rb
Original file line number Diff line number Diff line change
@@ -31,6 +31,6 @@ def summarize!
private

def pending_notification_requests
@pending_notification_requests ||= notification_requests.where(dismissed: false).limit(MAX_MEANINGFUL_COUNT).pick(Arel.sql('count(*), coalesce(sum(notifications_count), 0)::bigint'))
@pending_notification_requests ||= notification_requests.limit(MAX_MEANINGFUL_COUNT).pick(Arel.sql('count(*), coalesce(sum(notifications_count), 0)::bigint'))
end
end
5 changes: 2 additions & 3 deletions app/models/notification_request.rb
Original file line number Diff line number Diff line change
@@ -9,12 +9,13 @@
# from_account_id :bigint(8) not null
# last_status_id :bigint(8)
# notifications_count :bigint(8) default(0), not null
# dismissed :boolean default(FALSE), not null
# created_at :datetime not null
# updated_at :datetime not null
#

class NotificationRequest < ApplicationRecord
self.ignored_columns += %w(dismissed)

include Paginable

MAX_MEANINGFUL_COUNT = 100
@@ -34,8 +35,6 @@ def self.preload_cache_collection(requests)
end

def reconsider_existence!
return if dismissed?

prepare_notifications_count

if notifications_count.positive?
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# frozen_string_literal: true

class RemoveDismissedFromNotificationRequests < ActiveRecord::Migration[7.1]
def up
safety_assured do
execute 'DELETE FROM notification_requests WHERE dismissed'
remove_column :notification_requests, :dismissed
end
end

def down
add_column :notification_requests, :dismissed, :boolean, default: false, null: false
end
end
4 changes: 1 addition & 3 deletions db/schema.rb
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema[7.1].define(version: 2024_06_07_094856) do
ActiveRecord::Schema[7.1].define(version: 2024_07_12_064044) do
# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"

@@ -706,11 +706,9 @@
t.bigint "from_account_id", null: false
t.bigint "last_status_id"
t.bigint "notifications_count", default: 0, null: false
t.boolean "dismissed", default: false, null: false
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.index ["account_id", "from_account_id"], name: "index_notification_requests_on_account_id_and_from_account_id", unique: true
t.index ["account_id", "id"], name: "index_notification_requests_on_account_id_and_id", order: { id: :desc }, where: "(dismissed = false)"
t.index ["from_account_id"], name: "index_notification_requests_on_from_account_id"
t.index ["last_status_id"], name: "index_notification_requests_on_last_status_id"
end
1 change: 0 additions & 1 deletion spec/fabricators/notification_request_fabricator.rb
Original file line number Diff line number Diff line change
@@ -4,5 +4,4 @@
account
from_account { Fabricate.build(:account) }
last_status { Fabricate.build(:status) }
dismissed false
end
12 changes: 1 addition & 11 deletions spec/models/notification_request_spec.rb
Original file line number Diff line number Diff line change
@@ -4,9 +4,7 @@

RSpec.describe NotificationRequest do
describe '#reconsider_existence!' do
subject { Fabricate(:notification_request, dismissed: dismissed) }

let(:dismissed) { false }
subject { Fabricate(:notification_request) }

context 'when there are remaining notifications' do
before do
@@ -28,14 +26,6 @@
subject.reconsider_existence!
end

context 'when dismissed' do
let(:dismissed) { true }

it 'leaves request intact' do
expect(subject.destroyed?).to be false
end
end

it 'removes the request' do
expect(subject.destroyed?).to be true
end
18 changes: 3 additions & 15 deletions spec/requests/api/v1/notifications/requests_spec.rb
Original file line number Diff line number Diff line change
@@ -17,7 +17,6 @@

before do
Fabricate(:notification_request, account: user.account)
Fabricate(:notification_request, account: user.account, dismissed: true)
end

it_behaves_like 'forbidden for wrong scope', 'write write:notifications'
@@ -29,16 +28,6 @@
expect(response).to have_http_status(200)
end
end

context 'with dismissed' do
let(:params) { { dismissed: '1' } }

it 'returns http success', :aggregate_failures do
subject

expect(response).to have_http_status(200)
end
end
end

describe 'POST /api/v1/notifications/requests/:id/accept' do
@@ -78,15 +67,14 @@
post "/api/v1/notifications/requests/#{notification_request.id}/dismiss", headers: headers
end

let(:notification_request) { Fabricate(:notification_request, account: user.account) }
let!(:notification_request) { Fabricate(:notification_request, account: user.account) }

it_behaves_like 'forbidden for wrong scope', 'read read:notifications'

it 'returns http success and dismisses the notification request', :aggregate_failures do
subject
it 'returns http success and destroys the notification request', :aggregate_failures do
expect { subject }.to change(NotificationRequest, :count).by(-1)

expect(response).to have_http_status(200)
expect(notification_request.reload.dismissed?).to be true
end

context 'when notification request belongs to someone else' do
33 changes: 33 additions & 0 deletions spec/services/notify_service_spec.rb
Original file line number Diff line number Diff line change
@@ -129,6 +129,39 @@
end
end

context 'with filtered notifications' do
let(:unknown) { Fabricate(:account, username: 'unknown') }
let(:status) { Fabricate(:status, account: unknown) }
let(:activity) { Fabricate(:mention, account: recipient, status: status) }
let(:type) { :mention }

before do
Fabricate(:notification_policy, account: recipient, filter_not_following: true)
end

it 'creates a filtered notification' do
expect { subject }.to change(Notification, :count)
expect(Notification.last).to be_filtered
end

context 'when no notification request exists' do
it 'creates a notification request' do
expect { subject }.to change(NotificationRequest, :count)
end
end

context 'when a notification request exists' do
let!(:notification_request) do
Fabricate(:notification_request, account: recipient, from_account: unknown, last_status: Fabricate(:status, account: unknown))
end

it 'updates the existing notification request' do
expect { subject }.to_not change(NotificationRequest, :count)
expect(notification_request.reload.last_status).to eq status
end
end
end

describe NotifyService::DismissCondition do
subject { described_class.new(notification) }