Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NWB schema 2.8.0 #2001

Merged
merged 22 commits into from
Nov 25, 2024
Merged

Support NWB schema 2.8.0 #2001

merged 22 commits into from
Nov 25, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 20, 2024

Motivation

NWB schema 2.8.0 will be released this week. This branch tracks PRs that add support for various changes to the schema. When this is ready to merge, it should be merged without squashing in order to keep individual commit/PR history.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly
Copy link
Contributor Author

rly commented Nov 20, 2024

See pending 2.8.0 release: NeurodataWithoutBorders/nwb-schema#597

TODO:

  • After NWB schema 2.8.0 release, update the submodule to point to the 2.8.0 tag

@rly rly added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users labels Nov 20, 2024
@rly rly added this to the 3.0 milestone Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (54c655f) to head (8834110).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/pynwb/ecephys.py 66.66% 0 Missing and 1 partial ⚠️
src/pynwb/image.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2001      +/-   ##
==========================================
- Coverage   92.04%   91.88%   -0.17%     
==========================================
  Files          27       27              
  Lines        2704     2711       +7     
  Branches      705      707       +2     
==========================================
+ Hits         2489     2491       +2     
- Misses        141      144       +3     
- Partials       74       76       +2     
Flag Coverage Δ
integration 72.85% <66.66%> (-0.08%) ⬇️
unit 82.84% <83.33%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rly rly marked this pull request as ready for review November 25, 2024 06:33
@rly rly requested a review from stephprince November 25, 2024 06:33
stephprince
stephprince previously approved these changes Nov 25, 2024
@rly rly requested a review from stephprince November 25, 2024 07:15
@rly rly enabled auto-merge (squash) November 25, 2024 07:16
@rly rly merged commit 7087f00 into dev Nov 25, 2024
24 checks passed
@rly rly deleted the nwb_schema_2.8.0 branch November 25, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants