-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation example for DecompositionSeries #1981
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1981 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 27 27
Lines 2704 2704
Branches 705 705
=======================================
Hits 2489 2489
Misses 141 141
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Hi @stephprince. I replicated this example in the ecephys tutorial for matnwb and then I ran nwbinspector on the output file. The nwbinspector errored out before generating the results with the following error: I thought it was something matnwb specific, but got the same issue when running nwb inspector on the output of the pynwb tutorial with the new DecompositionSeries example. Could you check if you see the same? |
@ehennestad which version of the schema were you using? I'm waiting to merge this until we release version 2.8.0 of the schema, because this current example will generate invalid files until I get the same error as you with the current example + schema, but the inspector should run ok on the file if you change the code to be: for band_name, band_limits in bands.items():
decomp_series.add_band(band_name=band_name, band_limits=band_limits, band_mean=1.0, band_stdev=1.0) but I don't think |
I was using v2.7.0. Thanks for pointing that out again about the extra required properties. I had tried to add them, but found a typo and after correcting that, it works! |
@rly I've updated the example to add the required Once schema v2.8.0 is released, we can update this tutorial to remove those optional columns. |
Motivation
Fix #1938.
Note that this example is pending these schema updates: NeurodataWithoutBorders/nwb-schema#593, which makeband_mean
andband_std
optional.How to test the behavior?
Checklist
ruff check . && codespell
from the source directory.