Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure/simplify plot_file gallery #1914

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Restructure/simplify plot_file gallery #1914

merged 4 commits into from
Jun 13, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 12, 2024

Motivation

The NWB basics tutorial is good but had a little too much detail. More detail than we typically explain in the ~20 minute introduction in our events.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from bendichter June 12, 2024 22:56
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (04a6506) to head (130678c).
Report is 21 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1914   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files          27       27           
  Lines        2651     2651           
  Branches      692      692           
=======================================
  Hits         2436     2436           
  Misses        142      142           
  Partials       73       73           
Flag Coverage Δ
integration 72.80% <ø> (ø)
unit 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly
Copy link
Contributor Author

rly commented Jun 13, 2024

Workflow notes:

  • Check Sphinx Links workflow is failing because of a new warning in the CI. For the sake of merging this for the presentation tomorrow, I will merge this now and address the warning in a separate PR.
  • The Conda issues appear to be due to a random and unrelated unsafe threading issue.

@rly rly merged commit 194ce9c into dev Jun 13, 2024
24 of 25 checks passed
@rly rly deleted the restructure_plot_file branch June 13, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants