Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell codespell to ignore "assertIn" #1909

Merged
merged 2 commits into from
May 28, 2024
Merged

Tell codespell to ignore "assertIn" #1909

merged 2 commits into from
May 28, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented May 28, 2024

Motivation

The latest version of codespell causes 10+ new check failures because it introduced the check/correction assertIn ==> asserting, assert in, assertion. We use assertIn in tests.
This PR tells codespell to ignore the word "assertIn".

See codespell-project/codespell#3430

This is super minor and I think it does not merit a changelog entry.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (2f851df) to head (ed41064).
Report is 17 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1909   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files          27       27           
  Lines        2643     2643           
  Branches      689      689           
=======================================
  Hits         2434     2434           
  Misses        139      139           
  Partials       70       70           
Flag Coverage Δ
integration 73.13% <ø> (ø)
unit 84.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly requested review from mavaylon1 and stephprince and removed request for mavaylon1 May 28, 2024 22:58
@rly
Copy link
Contributor Author

rly commented May 28, 2024

Some tests are failing because of unrelated issues related to the Zarr tutorial.

@rly rly enabled auto-merge (squash) May 28, 2024 23:02
@rly rly merged commit 05756f9 into dev May 28, 2024
20 of 24 checks passed
@rly rly deleted the rly-patch-1 branch May 28, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants