Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Do not auto-set timezone, allow date (#1886)" #1908

Merged
merged 6 commits into from
May 29, 2024
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented May 28, 2024

This reverts commit ff1a03c from #1886.

Motivation

DANDI is having issues publishing datasets without a timezone. While this is being resolved, the team decided to revert the change that removes automatically setting a timezone when it is missing. Partially reverting #1886 is likely to mess up the new tests, so for time efficiency, I am reverting the entire PR. We can revert this when the DANDI issues have been resolved.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (05756f9) to head (7a8bce5).
Report is 16 commits behind head on dev.

Files Patch % Lines
src/pynwb/file.py 66.66% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1908      +/-   ##
==========================================
- Coverage   92.09%   91.88%   -0.21%     
==========================================
  Files          27       27              
  Lines        2643     2651       +8     
  Branches      689      692       +3     
==========================================
+ Hits         2434     2436       +2     
- Misses        139      142       +3     
- Partials       70       73       +3     
Flag Coverage Δ
integration 72.80% <57.69%> (-0.34%) ⬇️
unit 83.96% <69.23%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly requested a review from stephprince May 28, 2024 23:00
stephprince
stephprince previously approved these changes May 29, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Steph Prince <[email protected]>
@rly rly merged commit a7d585e into dev May 29, 2024
21 of 25 checks passed
@rly rly deleted the revert_timezone_change branch May 29, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants