Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "bounds" to SpatialSeries fields #1907

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented May 22, 2024

Motivation

I noticed that pynwb tests were passing with NWB schema 2.7.0 even though "bounds" was not added to SpatialSeries until after NWB schema 2.7.0, so really the IO tests should fail.

Until then, on the dev branch, "bounds" in SpatialSeries.__init__ will not be written to disk because it is missing from __nwbfields__.

Using the convenience test classes can hide this error. I think we should be more explicit when writing roundtrip tests to ensure that all expected fields are read correctly from the written file.

This PR merges into a new nwb_schema_2.8.0 branch.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (dc98e84) to head (9d967e6).
Report is 1 commits behind head on nwb_schema_2.8.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           nwb_schema_2.8.0    #1907   +/-   ##
=================================================
  Coverage             91.85%   91.85%           
=================================================
  Files                    27       27           
  Lines                  2689     2689           
  Branches                701      701           
=================================================
  Hits                   2470     2470           
  Misses                  145      145           
  Partials                 74       74           
Flag Coverage Δ
integration 72.62% <100.00%> (ø)
unit 83.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly changed the base branch from dev to nwb_schema_2.8.0 June 27, 2024 23:38
@rly rly marked this pull request as ready for review September 20, 2024 05:06
@rly rly requested a review from stephprince September 20, 2024 21:00
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@rly rly merged commit 7b73185 into nwb_schema_2.8.0 Oct 1, 2024
24 checks passed
@rly rly deleted the spatialseries_bounds branch October 1, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants