Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve get_data_in_units docstring #1880

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Improve get_data_in_units docstring #1880

merged 3 commits into from
Apr 1, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 1, 2024

Follow-up to #1878 to fix a broken link and clarify the docstring further to reflect the behavior of channel_conversion.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested review from bendichter and CodyCBakerPhD April 1, 2024 07:34
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.81%. Comparing base (9af54a2) to head (f168907).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1880   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files          27       27           
  Lines        2627     2627           
  Branches      688      688           
=======================================
  Hits         2412     2412           
  Misses        142      142           
  Partials       73       73           
Flag Coverage Δ
integration 72.47% <ø> (ø)
unit 83.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter bendichter enabled auto-merge (squash) April 1, 2024 14:00
@bendichter bendichter merged commit 2259bed into dev Apr 1, 2024
23 checks passed
@bendichter bendichter deleted the rly-patch-1 branch April 1, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants