Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more stimulus types #1842

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Support more stimulus types #1842

merged 12 commits into from
Feb 6, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Feb 5, 2024

Motivation

PR to support schema changes in NeurodataWithoutBorders/nwb-schema#559

How to test the behavior?

python test.py

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly changed the base branch from dev to nwb-schema-2.7.0 February 5, 2024 09:38
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (40e760c) 92.02% compared to head (32a61ff) 92.01%.

Files Patch % Lines
src/pynwb/file.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           nwb-schema-2.7.0    #1842      +/-   ##
====================================================
- Coverage             92.02%   92.01%   -0.02%     
====================================================
  Files                    27       27              
  Lines                  2633     2641       +8     
  Branches                690      693       +3     
====================================================
+ Hits                   2423     2430       +7     
  Misses                  138      138              
- Partials                 72       73       +1     
Flag Coverage Δ
integration 70.73% <53.84%> (-0.14%) ⬇️
unit 83.75% <92.30%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly marked this pull request as ready for review February 5, 2024 21:49
@rly rly requested review from oruebel and CodyCBakerPhD February 5, 2024 22:04
@CodyCBakerPhD
Copy link
Collaborator

Tests look good to me; I'll follow up with any issues when I reconvert the visual coding dataset

@rly rly merged commit 5c760da into nwb-schema-2.7.0 Feb 6, 2024
22 of 23 checks passed
@rly rly deleted the more_stimulus_types branch February 6, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants