Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Zarr tutorial #1835

Merged
merged 10 commits into from
Jan 29, 2024
Merged

Improve Zarr tutorial #1835

merged 10 commits into from
Jan 29, 2024

Conversation

bendichter
Copy link
Contributor

No description provided.

@bendichter bendichter requested a review from rly January 29, 2024 21:33
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c87ffd) 91.99% compared to head (a24369f) 91.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1835   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          27       27           
  Lines        2623     2623           
  Branches      685      685           
=======================================
  Hits         2413     2413           
  Misses        138      138           
  Partials       72       72           
Flag Coverage Δ
integration 71.10% <ø> (ø)
unit 83.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oruebel
oruebel previously approved these changes Jan 29, 2024
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You may want to crop the empty space at the top of thumbnail, but that's just nitpicking ;-)

@rly
Copy link
Contributor

rly commented Jan 29, 2024

The broken external link is unrelated -- it looks like one of the scicrunch resolvers might be down. We can adjust the URL if it's not back up in a few days..

@bendichter bendichter merged commit c40df49 into dev Jan 29, 2024
23 of 24 checks passed
@bendichter bendichter deleted the docs_zarr_tutorial branch January 29, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants