Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OptogeneticSeries to allow 2D data #1812

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 4, 2024

Motivation

Corresponds to schema changes in NeurodataWithoutBorders/nwb-schema#564

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5be83b6) 91.99% compared to head (ccc4538) 91.99%.

Additional details and impacted files
@@                Coverage Diff                @@
##           nwb-schema-2.7.0    #1812   +/-   ##
=================================================
  Coverage             91.99%   91.99%           
=================================================
  Files                    27       27           
  Lines                  2623     2623           
  Branches                685      685           
=================================================
  Hits                   2413     2413           
  Misses                  138      138           
  Partials                 72       72           
Flag Coverage Δ
integration 71.10% <ø> (ø)
unit 83.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly added this to the Next Release milestone Jan 9, 2024
@rly rly changed the base branch from dev to nwb-schema-2.7.0 January 11, 2024 22:52
@rly rly requested a review from stephprince January 11, 2024 22:53
src/pynwb/ogen.py Outdated Show resolved Hide resolved
Co-authored-by: Steph Prince <[email protected]>
@rly rly merged commit d0c4068 into nwb-schema-2.7.0 Jan 11, 2024
23 checks passed
@rly rly deleted the optogeneticseries_2d branch January 11, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants