Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_data_in_units work with channel_conversion #1806

Merged

Conversation

h-mayorquin
Copy link
Contributor

@h-mayorquin h-mayorquin commented Dec 18, 2023

Motivation

Fix #1797

How to test the behavior?

Added test

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac17d17) 91.98% compared to head (a90c213) 91.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1806   +/-   ##
=======================================
  Coverage   91.98%   91.99%           
=======================================
  Files          27       27           
  Lines        2620     2623    +3     
  Branches      684      685    +1     
=======================================
+ Hits         2410     2413    +3     
  Misses        138      138           
  Partials       72       72           
Flag Coverage Δ
integration 71.10% <0.00%> (-0.09%) ⬇️
unit 83.68% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h-mayorquin h-mayorquin marked this pull request as ready for review December 18, 2023 12:02
@h-mayorquin h-mayorquin changed the title Add get units to electrical series Make get_data_in_units work with channel_conversion Dec 18, 2023
@rly
Copy link
Contributor

rly commented Dec 21, 2023

Looks good. Thanks for the PR @h-mayorquin !

@rly rly merged commit 17b5621 into NeurodataWithoutBorders:dev Dec 21, 2023
23 of 24 checks passed
@h-mayorquin h-mayorquin deleted the add_get_units_to_electrical_series branch December 21, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: get_data_in_units fails for ElectricalSeries with channel_conversion
2 participants