Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nightly dandi read workflow for now #1794

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 6, 2023

Motivation

We recently added a github action to read a random set of nwb files from dandi. This always fails, usually after running for 2+ hours. The errors are almost always curl errors from using the ROS3 driver. This is not very informative until we have the bandwidth to use fsspec or remfile instead. I suggest we disable this workflow for now so that we don't waste compute cycles and I stop getting workflow failure emails.

Also Yarik raised a good point that stochastic testing is not ideal - you might miss a bug simply due to bad luck. We should test systematically instead of randomly, e.g., scan through dandisets 000001-000100 on monday, 000101-000200 on tuesday, etc.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel December 6, 2023 01:33
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60ec8fe) 91.99% compared to head (a3a64a8) 83.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1794      +/-   ##
==========================================
- Coverage   91.99%   83.68%   -8.32%     
==========================================
  Files          27       27              
  Lines        2623     2623              
  Branches      685      685              
==========================================
- Hits         2413     2195     -218     
- Misses        138      344     +206     
- Partials       72       84      +12     
Flag Coverage Δ
integration ?
unit 83.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oruebel
oruebel previously approved these changes Dec 6, 2023
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create an issue for future reference and add a comment in the yaml file stating why the workflow is disabled, just to leave breadcrumbs for ourselves

@rly rly requested a review from oruebel December 14, 2023 07:02
@rly rly enabled auto-merge (squash) January 12, 2024 00:34
@rly rly merged commit 1529028 into dev Jan 12, 2024
22 of 23 checks passed
@rly rly deleted the disable_dandi_read_workflow branch January 12, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants