Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings from tests #1778

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Fix warnings from tests #1778

merged 3 commits into from
Oct 4, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Oct 4, 2023

Motivation

Recent changes to HDMF remove the warning that there are no cached namespaces when loading namespaces and adds the warning that an object A with a DynamicTableRegion that points to table B is being added to another object C but table B and object C do not share an ancestor. Some tests fail or raise new warnings because of these changes. This PR addresses those.

Also updates the test_read_dandi.py test to not run when calling pytest and to not exceed the 360 minutes runtime allowed by GitHub Actions.

How to test the behavior?

Run test suite and also observe CI logs

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1778 (0cecd30) into dev (4656c08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1778   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files          27       27           
  Lines        2608     2608           
  Branches      681      681           
=======================================
  Hits         2399     2399           
  Misses        134      134           
  Partials       75       75           
Flag Coverage Δ
integration 71.24% <ø> (ø)
unit 83.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rly rly requested a review from oruebel October 4, 2023 02:05
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rly rly merged commit 97ea603 into dev Oct 4, 2023
23 checks passed
@rly rly deleted the fix_test_warnings branch October 4, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants