-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add driver argument to new validation functions #1588
Conversation
I'll also add the |
Codecov Report
@@ Coverage Diff @@
## dev #1588 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 25 25
Lines 2534 2534
Branches 481 481
=======================================
Hits 2314 2314
Misses 139 139
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…thub.com/neurodatawithoutborders/pynwb into allow_driver_specification_in_validation
This looks good. You can add to https://github.com/NeurodataWithoutBorders/pynwb/tree/dev/tests/integration/ros3 which is the only other place in the tests where we test different drivers. |
This looks like a fix specifically for ros3. It's good to support, but let's try to shift our default over to fsspec for all streaming stuff |
|
OK - added tests for the new keyword injections |
Oh wow, forgot about this one. Thanks @rly |
When working on NeurodataWithoutBorders/nwbinspector#265 (the integration of the recent validation changes into the NWB Inspector) I ran into an issue getting the cached namespaces for files when using the streaming mode of the Inspector.
Traced it back to these particular function calls - thankfully,
NWBHDF5IO.load_namespaces(...)
already supports adriver
keyword argument, we just need to add control and propagate it as shown here.@rly What would your recommendations be for adding tests for this?