Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust github actions to use setup-miniconda #525

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Adjust github actions to use setup-miniconda #525

merged 3 commits into from
Oct 2, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Oct 2, 2024

Tests that use the s-weigand/setup-conda action are failing on Windows. Replace with conda-incubator/setup-miniconda. Also update some versions of GH Actions used.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (c453b68) to head (d2341c0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #525      +/-   ##
==========================================
+ Coverage   82.77%   86.83%   +4.05%     
==========================================
  Files          47       47              
  Lines        1504     1504              
==========================================
+ Hits         1245     1306      +61     
+ Misses        259      198      -61     

see 5 files with indirect coverage changes

@rly
Copy link
Contributor Author

rly commented Oct 2, 2024

Some workflows were using conda when it did not need to IMO. So I removed that call. Only the ros3 one needed conda.

@rly rly requested a review from stephprince October 2, 2024 19:18
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I don't think a CHANGELOG is necessary for the workflow changes unless you want to add one.

And thanks for updating the workflows that don't need conda. I believe the workflows using conda that did not need to were the ones recently updated in the PRs that replaced ros3 with remfile.

@rly rly merged commit 5a0141a into dev Oct 2, 2024
37 of 38 checks passed
@rly rly deleted the conda-action branch October 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants