Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic removal of unused f-strings #516

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Contributor

Motivation

Pretty handy - merge before #513 to cleanup changes

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 25, 2024
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very handy!

@stephprince
Copy link
Contributor

The failing tests are from h5py that you're pinning in the other PR from what I understand

@CodyCBakerPhD
Copy link
Contributor Author

The failing tests are from h5py that you're pinning in the other PR from what I understand

Yeh hopefully that is resolved soon. Pretty big blunder on their part

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) September 26, 2024 06:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.96%. Comparing base (4266756) to head (04d2eca).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #516      +/-   ##
==========================================
+ Coverage   79.49%   84.96%   +5.46%     
==========================================
  Files          47       47              
  Lines        1390     1390              
==========================================
+ Hits         1105     1181      +76     
+ Misses        285      209      -76     

see 5 files with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD merged commit ea18bf6 into dev Sep 26, 2024
36 of 38 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the auto_purge_bad_fstrings branch September 26, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants