-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap to pyproject.toml setup #507
Conversation
docs/.readthedocs.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied over these two RTD files to start a smooth transition to keeping the files there instead of the outer level to reduce clutter
It works fine as long as the settings on the RTD admin page are adjusted, which is why I will wait until after this PR is merged to do that and then remove the files still at the outer level (so it doesn't break on the other current PRs)
"Operating System :: MacOS", | ||
"License :: OSI Approved :: BSD License", | ||
] | ||
requires-python = ">=3.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also removes Python 3.8 support, which ends its security upgrades next month
This will take a bit more work - will splinter a few items into smaller PRs |
@stephprince OK this is ready now I'll remove the RTD files on the outer level in a followup so the docs have a smooth transition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Added a couple small suggestions.
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #507 +/- ##
==========================================
+ Coverage 79.56% 84.96% +5.39%
==========================================
Files 48 47 -1
Lines 1390 1390
==========================================
+ Hits 1106 1181 +75
+ Misses 284 209 -75
|
Modern Pythonic practice has moved away from
setup.py
+/-.cfg
towardspyproject.toml
This updates the package accordingly