Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to pyproject.toml setup #507

Merged
merged 15 commits into from
Sep 17, 2024
Merged

Swap to pyproject.toml setup #507

merged 15 commits into from
Sep 17, 2024

Conversation

CodyCBakerPhD
Copy link
Contributor

Modern Pythonic practice has moved away from setup.py +/- .cfg towards pyproject.toml

This updates the package accordingly

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 6, 2024
CodyCBakerPhD added 2 commits September 6, 2024 12:01
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied over these two RTD files to start a smooth transition to keeping the files there instead of the outer level to reduce clutter

It works fine as long as the settings on the RTD admin page are adjusted, which is why I will wait until after this PR is merged to do that and then remove the files still at the outer level (so it doesn't break on the other current PRs)

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
"Operating System :: MacOS",
"License :: OSI Approved :: BSD License",
]
requires-python = ">=3.9"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also removes Python 3.8 support, which ends its security upgrades next month

@CodyCBakerPhD
Copy link
Contributor Author

This will take a bit more work - will splinter a few items into smaller PRs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 17, 2024 15:30
@CodyCBakerPhD
Copy link
Contributor Author

@stephprince OK this is ready now

I'll remove the RTD files on the outer level in a followup so the docs have a smooth transition

Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Added a couple small suggestions.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
CodyCBakerPhD and others added 2 commits September 17, 2024 13:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Steph Prince <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Steph Prince <[email protected]>
pyproject.toml Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.96%. Comparing base (e3cc7e2) to head (d7d5597).

Files with missing lines Patch % Lines
src/nwbinspector/version/__init__.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #507      +/-   ##
==========================================
+ Coverage   79.56%   84.96%   +5.39%     
==========================================
  Files          48       47       -1     
  Lines        1390     1390              
==========================================
+ Hits         1106     1181      +75     
+ Misses        284      209      -75     
Files with missing lines Coverage Δ
src/nwbinspector/_nwbinspector_cli.py 89.18% <100.00%> (+5.40%) ⬆️
src/nwbinspector/version/__init__.py 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD merged commit 4266756 into dev Sep 17, 2024
38 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the toml_setup branch September 17, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants