Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up imports a bit #498

Merged
merged 4 commits into from
Sep 1, 2024
Merged

clean up imports a bit #498

merged 4 commits into from
Sep 1, 2024

Conversation

bendichter
Copy link
Contributor

  • stay away from private modules
  • use Type when indicating that an arg should be a class

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (910ceba) to head (14e7029).
Report is 3 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #498      +/-   ##
==========================================
+ Coverage   82.06%   82.16%   +0.10%     
==========================================
  Files          47       47              
  Lines        1355     1357       +2     
==========================================
+ Hits         1112     1115       +3     
+ Misses        243      242       -1     
Flag Coverage Δ
unittests 82.16% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/nwbinspector/_configuration.py 96.22% <100.00%> (ø)
src/nwbinspector/_formatting.py 87.59% <100.00%> (+0.18%) ⬆️
src/nwbinspector/_inspection.py 83.08% <100.00%> (ø)

... and 1 file with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD merged commit 91799e8 into dev Sep 1, 2024
34 of 36 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the import-cleanup branch September 1, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants