Setup initial ruff #496
Merged
Setup initial ruff #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
CodyCBakerPhD
commented
Aug 31, 2024
| @@ -29,6 +29,7 @@ | |||
| "Importance", | |||
| "Severity", | |||
| "InspectorMessage", | |||
| "validate_config", | |||
There was a problem hiding this comment.
This caught one more
CodyCBakerPhD
commented
Aug 31, 2024
| @@ -1,9 +1,6 @@ | |||
| """Primary decorator used on a check function to add it to the registry and automatically parse its output.""" | |||
|
|
|||
| from collections.abc import Iterable | |||
There was a problem hiding this comment.
And cleaned up many others (unused imports)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #496 +/- ##
==========================================
+ Coverage 81.99% 82.06% +0.07%
==========================================
Files 47 47
Lines 1366 1355 -11
==========================================
- Hits 1120 1112 -8
+ Misses 246 243 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bendichter
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is also a general way, without relying on testing suite, to catch any potential issues like those in #494
Plan over next month was also to improve automatic linting and isorting in this manner, but easiest sometimes to add one selection at a time