Add cli with config tests #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Proof of intended failure
|
CodyCBakerPhD
commented
Aug 31, 2024
Comment on lines
90
to
+91
| class TestInspector(TestCase): | ||
| """A common helper class for testing the NWBInspector.""" |
There was a problem hiding this comment.
Peeled out this class so the helpers for asserting log file contents can be used across the suite
Might be worth moving to nwbinspector.testing in a follow-up
…atawithoutborders/nwbinspector into add_cli_with_config_tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #495 +/- ##
==========================================
+ Coverage 82.06% 82.14% +0.07%
==========================================
Files 47 47
Lines 1355 1355
==========================================
+ Hits 1112 1113 +1
+ Misses 243 242 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
bendichter
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Turns out we actually didn't have a CLI test for the
--config dandicaseAdded here, will fail until #494 is merged (at which point it should then pass)