Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import JSON encoder from formatting #488

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

stephprince
Copy link
Contributor

Motivation

During the organization refactoring, InspectorOutputJSONEncoder was moved to _formatting.py, but is still being imported from _configuration.py in the nwbinspector/nwbinspector/__init__.py file.

@CodyCBakerPhD
Copy link
Contributor

Thanks!

In a follow-up, can you also adjust sphinx class references such as

:py:class:`~nwbinspector.nwbinspector.inspect_nwb` function.
to use the outer module?

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) August 22, 2024 05:46
@CodyCBakerPhD CodyCBakerPhD merged commit f6aacb5 into dev Aug 22, 2024
36 of 37 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix-jsonencoder-import branch August 22, 2024 05:48
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.99%. Comparing base (2380ff8) to head (07ca4d2).
Report is 5 commits behind head on dev.

Files Patch % Lines
src/nwbinspector/nwbinspector/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #488      +/-   ##
==========================================
- Coverage   82.05%   81.99%   -0.07%     
==========================================
  Files          47       47              
  Lines        1365     1366       +1     
==========================================
  Hits         1120     1120              
- Misses        245      246       +1     
Flag Coverage Δ
unittests 81.99% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/nwbinspector/nwbinspector/__init__.py 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants