Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final scoping fix #487

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Final scoping fix #487

merged 2 commits into from
Aug 20, 2024

Conversation

CodyCBakerPhD
Copy link
Contributor

Motivation

@stephprince My bad; we had previously fixed the __init__.py for this submodule to the new standard but forgot to mark the lower levels as private with soft deprecations

This should be the last one like this unless my eyes missed something else

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.05%. Comparing base (bf93524) to head (829c64d).

Files Patch % Lines
src/nwbinspector/tools/dandi/__init__.py 0.00% 4 Missing ⚠️
src/nwbinspector/tools/nwb/__init__.py 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #487      +/-   ##
==========================================
- Coverage   82.53%   82.05%   -0.49%     
==========================================
  Files          45       47       +2     
  Lines        1357     1365       +8     
==========================================
  Hits         1120     1120              
- Misses        237      245       +8     
Flag Coverage Δ
unittests 82.05% <20.00%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/nwbinspector/tools/__init__.py 100.00% <100.00%> (ø)
src/nwbinspector/tools/_dandi.py 20.68% <ø> (ø)
src/nwbinspector/tools/_nwb.py 88.88% <ø> (ø)
src/nwbinspector/tools/dandi/__init__.py 0.00% <0.00%> (ø)
src/nwbinspector/tools/nwb/__init__.py 0.00% <0.00%> (ø)

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 20, 2024 15:20
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I also looked through and I think they're all fixed now.

@CodyCBakerPhD CodyCBakerPhD merged commit 2380ff8 into dev Aug 20, 2024
36 of 37 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the finish_scoping branch August 20, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants