-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve organization #485
Improve organization #485
Conversation
@stephprince I will ping you again once the internal routing is all unscrambled/debugged |
@stephprince OK this is ready now if you want to take a look before our meeting In the CHANGELOG I have emphasized what is being hard vs. soft deprecated Most classical imports from the API should still work with a deprecation warning Anything that this PR 'breaks' in terms of back-compatibility is for things that never should have been imported by users to begin with (various private functions we're not held accountable for exposing, third-party packages, etc.) Two follow-up PRs to this will include a similar treatment for the |
…thoutborders/nwbinspector into improve_organization
Co-authored-by: Cody Baker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #485 +/- ##
==========================================
- Coverage 87.14% 85.55% -1.60%
==========================================
Files 23 33 +10
Lines 1260 1308 +48
==========================================
+ Hits 1098 1119 +21
- Misses 162 189 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Motivation
@stephprince Here is the first refactor for improved package navigation
This implements modern sklearn-style private vs. public imports and properly scoped submodules (no things like
from nwbinspector.utils import os
allowed)No actual code has changed (+/- marking some very low level functions as private or public), just moving things around