Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing.yml to install h5py with ROS3 first #475

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 17, 2024

If you install h5py from conda-forge to get ROS3 support before installing nwbinspector, h5py does not get re-installed, so there is no need to uninstall it and create conflicting conda/pip issues later.

@rly rly requested a review from CodyCBakerPhD June 17, 2024 19:01
@CodyCBakerPhD CodyCBakerPhD merged commit d69b252 into bump_numpy Jun 17, 2024
1 of 2 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the rly-patch-1 branch June 17, 2024 19:34
CodyCBakerPhD added a commit that referenced this pull request Jun 19, 2024
* bump numpy

* Update assess-file-changes.yml

* Update testing.yml to install h5py with ROS3 first (#475)

* Update testing.yml

* add zarr to minimal

* adjust dev workflow

* remove past versions

---------

Co-authored-by: Cody Baker <[email protected]>

---------

Co-authored-by: Ryan Ly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants