fixed module search flag in nwbinspector #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks a bunch! Last thing, can you add a CHANGELOG entry with a category header |
|
LGTM! Thanks again |
CodyCBakerPhD
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was testing adding custom checks to nwbinspector using the '--modules' flag. I was initially facing an error where the nwbinspector was only reading the first character after the --modules flag. I realized that nwbinspector.py was expecting the modules to be input as a comma separated strings of modules, but there was no code to split this module string into a list of strings causing the string itself to be looped over as an iterable. I added a line of code that splits the modules string at the commas to yield a list of strings.