-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic outer level progress bar control #440
Conversation
Yep this works great! |
This PR is no longer functional with the GUIDE and requires #443 to be merged in. |
The GUIDE specifically doesn't utilize this particular route, but it might still be useful Or are you saying something overlooked here actually causes a problem with the GUIDE? |
There isn't a corresponding PR on the GUIDE that works solely for this. NeurodataWithoutBorders/nwb-guide#676 has been refactored to work with #443, but will fail when using this PR alone. |
@garrettmflynn Yes, I know. GUIDE specifically needs the next step of this chain But is there an actual problem with the actual part of the code in the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sure, this implementation is fine.
However you'd like to coordinate the merge is fine with me. Feel free to start here!
@garrettmflynn You should be able to use this draft branch to try out the approach for the Inspector
Right now there would just be one progress bar tracking the number of files left to be scanned