Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic outer level progress bar control #440

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Contributor

@garrettmflynn You should be able to use this draft branch to try out the approach for the Inspector

Right now there would just be one progress bar tracking the number of files left to be scanned

@garrettmflynn
Copy link
Member

Yep this works great!

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review April 22, 2024 19:08
@CodyCBakerPhD CodyCBakerPhD self-assigned this Apr 22, 2024
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) April 22, 2024 19:08
@garrettmflynn
Copy link
Member

This PR is no longer functional with the GUIDE and requires #443 to be merged in.

@CodyCBakerPhD
Copy link
Contributor Author

The GUIDE specifically doesn't utilize this particular route, but it might still be useful

Or are you saying something overlooked here actually causes a problem with the GUIDE?

@garrettmflynn
Copy link
Member

There isn't a corresponding PR on the GUIDE that works solely for this. NeurodataWithoutBorders/nwb-guide#676 has been refactored to work with #443, but will fail when using this PR alone.

@CodyCBakerPhD
Copy link
Contributor Author

@garrettmflynn Yes, I know. GUIDE specifically needs the next step of this chain

But is there an actual problem with the actual part of the code in the PR?

Copy link
Member

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sure, this implementation is fine.

However you'd like to coordinate the merge is fine with me. Feel free to start here!

@CodyCBakerPhD CodyCBakerPhD merged commit e6b4c2d into dev Apr 22, 2024
25 of 26 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the guide_progress_bars_1 branch April 22, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants