Separate workflows for testing dandi dev between live and no network #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Log run: https://github.com/NeurodataWithoutBorders/nwbinspector/actions/runs/7904129986/job/21573692473 shows successful separation and passing tests on non-network DANDI tests |
weiglszonja
reviewed
Feb 16, 2024
| on: workflow_call | ||
|
|
||
| env: | ||
| DANDI_TESTS_NONETWORK: "1" |
There was a problem hiding this comment.
Maybe it's just me, but at first I always read as "none twork" 😅
Suggested change
| DANDI_TESTS_NONETWORK: "1" | |
| DANDI_TESTS_NO_NETWORK: "1" |
There was a problem hiding this comment.
While I completely agree - this is the name of the environment variable that must be set to have this effect on the DANDI testing suite, so I cannot change it here
There was a problem hiding this comment.
ah okay, thanks for the clarification!
weiglszonja
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DANDI dev tests can sometimes fail due to live service issues like http://purl.obolibrary.org/ failing to respond (see dandi/dandi-cli#1405)
We should definitely still run all tests; but I'd prefer a separation so that when I get a notification of a failure, I can do a direct comparison between with network and without network, indicating that I should just wait a certain amount of time before rerunning the with network ones