Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tox from dandi dev tests #434

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Contributor

Motivation

From #433 (comment)

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review February 2, 2024 20:58
@CodyCBakerPhD CodyCBakerPhD self-assigned this Feb 2, 2024
@CodyCBakerPhD
Copy link
Contributor Author

Confirmed that we're now correctly testing dev Inspector against dev DANDI testing suite, and confirmed fix from #433

@yarikoptic Sorry for the bother, this shouldn't happen again

@jwodder Thanks for the pointer on tox; it was even written in comments inside that action, but guess we missed that detail when following directions from https://github.com/dandi/dandi-cli/blob/master/DEVELOPMENT.md#running-tests-locally

@CodyCBakerPhD CodyCBakerPhD merged commit ffde0e0 into dev Feb 2, 2024
23 of 24 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the try_removing_dandi_tox branch February 2, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant