Use paths instead of io in pynwb.validate call #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
CodyCBakerPhD
approved these changes
Dec 19, 2023
|
Ohhh I see - good idea! Thanks for the quick fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue in NeurodataWithoutBorders/pynwb#1777
In short,
validate(paths=[nwbfile_path])performs the expected behavior of validating against all cached namespaces in the file except for dependent ones andvalidate(io=io)does not. Changingvalidate(io=io)to perform the expected behavior would be a breaking change in pynwb. I think we should make that breaking change in pynwb as soon as possible, but given the urgency of the issue and thatvalidate(paths=[nwbfile_path])does the expected behavior, I think we should also change nwbinspector to usevalidate(paths=[nwbfile_path])now.