Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/fix-description-check-nonstring'…
Browse files Browse the repository at this point in the history
… into fix-description-check-nonstring
  • Loading branch information
bendichter committed Nov 24, 2024
2 parents 5fd89ba + fa93688 commit 3382ad7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repos:
- id: black

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.6.9
rev: v0.7.4
hooks:
- id: ruff
args: [ --fix ]
Expand All @@ -24,7 +24,7 @@ repos:
- tomli

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.11.2
rev: v1.13.0
hooks:
- id: mypy
additional_dependencies: ["types-PyYAML", "types-setuptools"]
5 changes: 1 addition & 4 deletions tests/unit_tests/test_general.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ def test_check_description_missing():

def test_check_description_feature_extraction():
import numpy as np

from pynwb.ecephys import FeatureExtraction
from pynwb.testing.mock.ecephys import mock_ElectrodeTable

Expand All @@ -68,10 +67,8 @@ def test_check_description_feature_extraction():
name="PCA_features",
electrodes=dynamic_table_region,
description=["PC1", "PC2", "PC3", "PC4"],
times=[.033, .066, .099],
times=[0.033, 0.066, 0.099],
features=np.random.rand(3, 5, 4), # time, channel, feature
)

assert check_description(neurodata_object=feature_extraction) is None


0 comments on commit 3382ad7

Please sign in to comment.