Skip to content

Commit

Permalink
Revert "Update TimeIntervals to use the new TimeSeriesReferenceVector…
Browse files Browse the repository at this point in the history
…Data" (#483)

* Revert "Update TimeIntervals to use the new TimeSeriesReferenceVectorData"

This reverts commit 0da613b.

* Update changelog to reflect reverted change to TimeIntervals
  • Loading branch information
rly authored Aug 9, 2021
1 parent 9d99119 commit c8f2d0b
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 9 deletions.
15 changes: 14 additions & 1 deletion core/nwb.epoch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,20 @@ groups:
doc: Index for tags.
quantity: '?'
- name: timeseries
neurodata_type_inc: TimeSeriesReferenceVectorData
neurodata_type_inc: VectorData
dtype:
- name: idx_start
dtype: int32
doc: Start index into the TimeSeries 'data' and 'timestamp' datasets of the
referenced TimeSeries. The first dimension of those arrays is always time.
- name: count
dtype: int32
doc: Number of data samples available in this time series, during this epoch.
- name: timeseries
dtype:
target_type: TimeSeries
reftype: object
doc: the TimeSeries that this index applies to.
doc: An index into a TimeSeries object.
quantity: '?'
- name: timeseries_index
Expand Down
9 changes: 1 addition & 8 deletions docs/format/source/format_release_notes.rst
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
Release Notes
=============

2.4.0 (Aug. 7, 2021)
2.4.0 (Aug. 11, 2021)
--------------------


Major changes
^^^^^^^^^^^^^
- Added new ``TimeSeriesReferenceVectorData`` type for referencing ranges of ``TimeSeries`` from a ``VectorData`` column (#470)
- Updated ``TimeIntervals`` to use the new ``TimeSeriesReferenceVectorData`` type. This does not alter the overall structure
of ``TimeIntervals`` in a major way aside from changing the value of the ``neurodata_type`` attribute in the file
from ``VectorData`` to ```TimeSeriesReferenceVectorData``. This change replaces the existing ``TimeIntervals.timeseries``
column with a ``TimeSeriesReferenceVectorData`` type column of the same name and overall schema. This change facilitate creating
common functionality around ``TimeSeriesReferenceVectorData``. This change affects all existing ``TimeIntervals`` tables
as part of the ``intervals/`` group, i.e., ``intervals/epochs``, ``intervals/trials``, and ``intervals/invalid_times`` (#482)
- Integrated the intracellular electrophysiology experiment metadata table structure developed as part of the
`ndx-icephys-meta <https://github.com/oruebel/ndx-icephys-meta>`_ extension project with NWB (#470). This includes the
following new types:
Expand Down

0 comments on commit c8f2d0b

Please sign in to comment.