Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug DANDI upload argument defaults #923

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Debug DANDI upload argument defaults #923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68b52cf
debug argument defaults
CodyCBakerPhD Aug 31, 2024
17ec80f
Merge branch 'main' into debug_dandi
CodyCBakerPhD Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/pyflask/manageNeuroconv/manage_neuroconv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,7 +1336,9 @@ def upload_multiple_filesystem_objects_to_dandi(**kwargs) -> list[Path]:
del innerKwargs["filesystem_paths"]
innerKwargs["nwb_folder_path"] = tmp_folder_path
results = upload_folder_to_dandi(**innerKwargs)
rmtree(tmp_folder_path)

rmtree(tmp_folder_path, ignore_errors=True)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed this, which can happen if you enable 'cleanup' option but cleanup succeeds in earlier stage (earlier stage is known to fail stochastically on certain platforms, which is why we try it again here)


return results


Expand Down Expand Up @@ -1364,8 +1366,8 @@ def upload_folder_to_dandi(
nwb_folder_path=Path(nwb_folder_path),
staging=staging,
cleanup=cleanup,
number_of_jobs=number_of_jobs,
number_of_threads=number_of_threads,
number_of_jobs=number_of_jobs or 1,
number_of_threads=number_of_threads or 1,
)


Expand Down
Loading