Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug windows e2e tests #921

Merged
merged 12 commits into from
Aug 25, 2024
Merged

Debug windows e2e tests #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
39b0812
Debug windows e2e tests
rly Aug 23, 2024
0e8f652
Test
rly Aug 23, 2024
f58da9c
Try to debug test dataset generation
rly Aug 23, 2024
23bd908
Try another way
rly Aug 23, 2024
d34dd5a
Merge branch 'main' into debug_windows_e2e
rly Aug 23, 2024
e81a83c
Try another way
rly Aug 23, 2024
7fd9363
Getting closer. Try to narrow scope of timeout increase
rly Aug 23, 2024
16e74ca
There are 60 seconds in a minute not 10
rly Aug 23, 2024
3439fe8
Increase timeout - 6 minutes is not enough
rly Aug 23, 2024
6328a3f
Remove likely unnecessary timeout settings
rly Aug 23, 2024
03da3e5
Increase beforeStartTimeout for failing macos example data test
rly Aug 23, 2024
fa74002
Merge branch 'main' into debug_windows_e2e
CodyCBakerPhD Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions tests/e2e/puppeteer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const beforeStart = (timeout) => new Promise(async (resolve, reject) => {
process.stdout.on('data', handleOutput);
process.stderr.on('data', handleOutput);
process.on('close', (code) => console.log(`[electron] Exited with code ${code}`));
await sleep(timeout) // Wait for five seconds for Electron to open
await sleep(timeout)

reject('Failed to open Electron window successfully.')
})
Expand All @@ -33,15 +33,13 @@ type BrowserTestOutput = {
browser?: puppeteer.Browser,
}

const beforeStartTimeout = 60 * 1000 // Wait for 1 minute for Electron to open (mostly for Windows)
const launchProtocolTimeout = 6 * 60 * 1000 // Creating the test dataset can take up to 6 minutes (mostly for Windows)
const beforeStartTimeout = 2 * 60 * 1000 // Wait 2 minutes for Electron to open
const protocolTimeout = 10 * 60 * 1000 // Creating the test dataset can take up to 10 minutes (mostly for Windows)

export const connect = () => {


const output: BrowserTestOutput = {}


beforeAll(async () => {

await beforeStart(beforeStartTimeout)
Expand All @@ -52,7 +50,7 @@ export const connect = () => {
});

const browserURL = `http://localhost:${electronDebugPort}`
const browser = output.browser = await puppeteer.launch({ headless: 'new', protocolTimeout: launchProtocolTimeout})
const browser = output.browser = await puppeteer.launch({ headless: 'new' })
const page = output.page = await browser.newPage();
await page.goto(browserURL);
const endpoint = await page.evaluate(() => fetch(`json/version`).then(res => res.json()).then(res => res.webSocketDebuggerUrl))
Expand All @@ -62,7 +60,7 @@ export const connect = () => {

// Connect to browser WS Endpoint
const browserWSEndpoint = endpoint.replace('localhost', '0.0.0.0')
output.browser = await puppeteer.connect({ browserWSEndpoint, defaultViewport: null })
output.browser = await puppeteer.connect({ browserWSEndpoint, defaultViewport: null, protocolTimeout: protocolTimeout})

const pages = await output.browser.pages()
output.page = pages[0]
Expand Down
4 changes: 3 additions & 1 deletion tests/e2e/tutorial.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ describe('E2E Test', () => {

const datasetTestFunction = config.regenerateTestData ? test : test.skip

datasetTestFunction('Create tutorial dataset', async () => {
// Wait up to 10 minutes for dataset generation
// Both the test timeout and the protocolTimeout on puppeteer.connect() must be set to 10 min
datasetTestFunction('Create tutorial dataset', { timeout: 10 * 60 * 1000 }, async () => {

await evaluate(async () => {

Expand Down
Loading