Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puppeteer, re-enable mac CI, split e2e CI #910

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Conversation

rly
Copy link
Collaborator

@rly rly commented Aug 13, 2024

Replace #902

rly and others added 4 commits August 13, 2024 16:48
for more information, see https://pre-commit.ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@rly rly requested a review from CodyCBakerPhD August 14, 2024 00:24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these submodules? I can't follow them anywhere

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! That was not intentional.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, did you actually make some GitHub repositories with our example testing data? And maybe git LFS? Because we've all wanted that for a really long time lol

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I accidentally added the testing data git repos as submodules. How would you want these repos/submodules to work?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I accidentally added the testing data git repos as submodules.

But that's what I'm confused about - there aren't any git repos currently (well, technically git-annex via GIN)

How would you want these repos/submodules to work?

Identically to the GIN repos, but better in all the ways that GitHub is better than GIN as a platform (and likely using Git LFS for any files that are larger than a few MB)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you recombine this with the main deployment again since it doesn't look like anything changed with how they are called?

The suggestion to peel out e2e step was on the lower workflow level, so that 'dev tests' only run vitetest and pytest, and puppeteer calls on pipelines with example data could be a separate npm run call

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh I see.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just something to keep in mind if this happens again. Fingers crossed it doesn't though

rly and others added 2 commits August 13, 2024 17:56

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
CodyCBakerPhD and others added 2 commits August 13, 2024 21:27

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…eployment_file
@CodyCBakerPhD CodyCBakerPhD merged commit 0970093 into main Aug 14, 2024
21 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the puppeteer branch August 14, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants