-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update puppeteer, re-enable mac CI, split e2e CI #910
Conversation
behavior_testing_data
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these submodules? I can't follow them anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! That was not intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, did you actually make some GitHub repositories with our example testing data? And maybe git LFS? Because we've all wanted that for a really long time lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I accidentally added the testing data git repos as submodules. How would you want these repos/submodules to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I accidentally added the testing data git repos as submodules.
But that's what I'm confused about - there aren't any git repos currently (well, technically git-annex via GIN)
How would you want these repos/submodules to work?
Identically to the GIN repos, but better in all the ways that GitHub is better than GIN as a platform (and likely using Git LFS for any files that are larger than a few MB)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you recombine this with the main deployment again since it doesn't look like anything changed with how they are called?
The suggestion to peel out e2e step was on the lower workflow level, so that 'dev tests' only run vitetest and pytest, and puppeteer calls on pipelines with example data could be a separate npm run
call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh I see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just something to keep in mind if this happens again. Fingers crossed it doesn't though
…eployment_file
Replace #902