Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strictly internal fix for SpikeGLX stub #908

Merged
merged 21 commits into from
Aug 13, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Collaborator

@CodyCBakerPhD CodyCBakerPhD commented Aug 7, 2024

replace #870

Testing to see if this passes

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 7, 2024
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 7, 2024 19:12
@CodyCBakerPhD CodyCBakerPhD requested a review from rly August 7, 2024 19:12
@CodyCBakerPhD
Copy link
Collaborator Author

CodyCBakerPhD commented Aug 7, 2024

@rly OK, this is ready and does not depend on NeuroConv

Had to pin back a day because the merge of catalystneuro/neuroconv#821 broke our dependencies for the tutorial generation

In general, going forward, you may want to consider looking into either poetry or a full conda freeze for the backend to mimic the stability of the frontend (postinstalls aside) to avoid situations just like this

@CodyCBakerPhD
Copy link
Collaborator Author

@rly Ping

@CodyCBakerPhD CodyCBakerPhD merged commit 08e2b06 into main Aug 13, 2024
14 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the strictly_internal_fix branch August 13, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants