Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MEArec build #880

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Fix MEArec build #880

merged 3 commits into from
Jun 24, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

#879

Added test case to pipelines

Ensured it works on local build

@CodyCBakerPhD CodyCBakerPhD requested a review from bendichter June 24, 2024 17:54
@CodyCBakerPhD CodyCBakerPhD self-assigned this Jun 24, 2024
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge June 24, 2024 17:57
@bendichter
Copy link
Collaborator

@CodyCBakerPhD would this work?

for pkg in (
    'dandi',
    'keyrings',
    'unittest',
    'nwbinspector',
    'neuroconv',
    'pynwb',
    'hdmf',
    'hdmf_zarr',
    'ndx_dandi_icephys',
    'sklearn',
    'ci_info',
    'tifffile',
    'dlc2nwb',
    'sleap_io',
    'ndx_pose',
    'tzdata',
    'elephant',
):
    tmp_ret = collect_all(pkg)
    datas += tmp_ret[0]; binaries += tmp_ret[1]; hiddenimports += tmp_ret[2]

@CodyCBakerPhD
Copy link
Collaborator Author

It should, went ahead and enhanced that

The only thing is if you ever regenerate the spec file via PyInstaller CLI, it'll get rid of that (the flat version is what is auto-compiled by it)

@CodyCBakerPhD CodyCBakerPhD merged commit 446aed6 into main Jun 24, 2024
21 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix_mearec branch June 24, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants