Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve correct icon for Electron builds #88

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Conversation

garrettmflynn
Copy link
Member

fix #87

Since it's proven to be quite difficult to actually resolve a custom icon on a Mac development build, ensure that the built version of the NWB GUIDE application has the correct icon by running:

npm run build-[platform]

Where platform is either win, mac, or linux based on the desired target OS.

You'll be able to find the built project in the /dist folder.

I can work more on resolving the icon in development for Mac—but I assume it might not be consequential if we can resolve it for the final build.

@garrettmflynn garrettmflynn self-assigned this Mar 28, 2023
@garrettmflynn garrettmflynn mentioned this pull request Mar 28, 2023
@garrettmflynn
Copy link
Member Author

I'd recommend testing this on the branch for #91, which fixes #90 (uncovered here) to ensure that the frontend is resolved properly.

@bendichter
Copy link
Collaborator

oh yeah I really only care about the final build. It's fine to have a default icon for development

@bendichter
Copy link
Collaborator

The icon looks right, but double-clicking it gives me this error:

image

@garrettmflynn
Copy link
Member Author

garrettmflynn commented Mar 28, 2023

@bendichter See #89. If y'all have any ideas why this is happening, I'd be very curious to know.

@garrettmflynn garrettmflynn marked this pull request as ready for review March 31, 2023 18:51
@CodyCBakerPhD
Copy link
Collaborator

So... is this still in progress? Draft? Stuck due to the M1 PyInstaller issue?

@garrettmflynn
Copy link
Member Author

Technically completed as much as we can since Mac generally doesn't like resolving the icons during development—though the Mac Pyinstaller issues are downstream of this.

When you build on Mac, you now get the right NWB GUIDE icon. You just also get an error about not having the Python server available.

@CodyCBakerPhD
Copy link
Collaborator

Ah, but do you need the changes from the PR to make that a possibility through the Mac build?

@garrettmflynn
Copy link
Member Author

This PR is decoupled from #89, though I'd uncovered the issue while completing this.

If we can push a working icon resolution without a functional Mac build, I'd suggest merging this.

@CodyCBakerPhD
Copy link
Collaborator

If we can push a working icon resolution without a functional Mac build, I'd suggest merging this.

Yeah, that's fine. It can be a known disconnect between dev and non-dev builds

@CodyCBakerPhD CodyCBakerPhD merged commit d109ed8 into main Apr 5, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the resolve-correct-icon branch April 5, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

system icon
3 participants