-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve correct icon for Electron builds #88
Conversation
oh yeah I really only care about the final build. It's fine to have a default icon for development |
@bendichter See #89. If y'all have any ideas why this is happening, I'd be very curious to know. |
So... is this still in progress? Draft? Stuck due to the M1 PyInstaller issue? |
Technically completed as much as we can since Mac generally doesn't like resolving the icons during development—though the Mac Pyinstaller issues are downstream of this. When you build on Mac, you now get the right NWB GUIDE icon. You just also get an error about not having the Python server available. |
Ah, but do you need the changes from the PR to make that a possibility through the Mac build? |
This PR is decoupled from #89, though I'd uncovered the issue while completing this. If we can push a working icon resolution without a functional Mac build, I'd suggest merging this. |
Yeah, that's fine. It can be a known disconnect between dev and non-dev builds |
fix #87
Since it's proven to be quite difficult to actually resolve a custom icon on a Mac development build, ensure that the built version of the NWB GUIDE application has the correct icon by running:
Where
platform
is eitherwin
,mac
, orlinux
based on the desired target OS.You'll be able to find the built project in the
/dist
folder.I can work more on resolving the icon in development for Mac—but I assume it might not be consequential if we can resolve it for the final build.