Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Page Mismatch after Cancelled Autoconversion #809

Merged
merged 5 commits into from
May 29, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/electron/frontend/core/components/Dashboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,15 @@
if (previous && previous.info.previous === this.page) await this.page.onTransition(-1);
else await this.page.onTransition(1);
}
});
}).catch((e) => {
const previousId = previous?.info?.id
if (previousId) {
page.onTransition(previousId); // Revert back to previous page
page.notify(`<h4 style="margin: 0">Fallback to previous page after error occured</h4><small>${e}</small>`, "error");

Check failure on line 275 in src/electron/frontend/core/components/Dashboard.js

View workflow job for this annotation

GitHub Actions / Check for spelling errors

occured ==> occurred
CodyCBakerPhD marked this conversation as resolved.
Show resolved Hide resolved
}

else reloadPageToHome();
})
}

// Populate the sections tracked for this page by using the global state as a model
Expand Down
Loading