Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor Flask II] Break up top-level #799

Merged
merged 15 commits into from
May 28, 2024
Merged

[Refactor Flask II] Break up top-level #799

merged 15 commits into from
May 28, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

Rebase and splinter of #796 specific to offloading various endpoints from the main app.py into distinct namespaces

@CodyCBakerPhD CodyCBakerPhD self-assigned this May 27, 2024
CodyCBakerPhD
CodyCBakerPhD commented May 27, 2024
View reviewed changes
prettier.config.js Outdated Show resolved Hide resolved
@CodyCBakerPhD CodyCBakerPhD changed the base branch from main to fix_prettier_formatting May 27, 2024 18:33
Base automatically changed from fix_prettier_formatting to main May 27, 2024 22:58
@CodyCBakerPhD
Copy link
Collaborator Author

Well, for reasons that are currently beyond me, our attempt last week to simplify the serving of paths to neurosift has been causing issues so I reverted to the previous structure and we can tackle it in a follow-up

If I go for the flask_restx.Resource structure inside a separate namespace (and adjust all fetches to that new namespace accordingly) I get

image

whereas it should normally look like

image

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review May 28, 2024 03:40
garrettmflynn
garrettmflynn approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for handling this!

@CodyCBakerPhD CodyCBakerPhD merged commit 6972133 into main May 28, 2024
21 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the break_up_endpoints branch May 28, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmflynn garrettmflynn garrettmflynn approved these changes

Assignees

@CodyCBakerPhD CodyCBakerPhD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodyCBakerPhD @garrettmflynn