Run on first page load and ensure conversion review has proper behavior #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Any way to add tests? (also some failing atm) |
for more information, see https://pre-commit.ci
…aWithoutBorders/nwb-guide into fix-sync-state-tracking
|
Gotcha thanks for flagging! Added a check to the tests so that |
CodyCBakerPhD
approved these changes
May 2, 2024
|
@garrettmflynn 2 pages in the storybook now fail to fetch - is this intended or do you know what's happening? |
|
Found the issue. Fixed |
for more information, see https://pre-commit.ci
CodyCBakerPhD
approved these changes
May 2, 2024
|
@garrettmflynn Main tests failing again |
garrettmflynn
commented
May 3, 2024
|
|
||
| const { desyncedData } = info.globalState; | ||
|
|
||
| f |
There was a problem hiding this comment.
Here's the culprit. Whoops!
|
Looks like one of my wonderful cats stepped on the keyboard and inserted a stray My bad! Works locally now |
😂 |
CodyCBakerPhD
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When going through a straight run of the SpikeGLX-Phy test pipeline, it was noticed that full and preview conversions were not being triggered.
This PR fixes this behavior to ensure that a preview conversion is triggered on the first run even if no manual changes have been made by the user. The behavior of the Conversion Review page has also been updated to trigger a conversion before reaching DANDI Upload.