Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer validation to form change #752

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Defer validation to form change #752

merged 4 commits into from
Apr 17, 2024

Conversation

garrettmflynn
Copy link
Member

fix #750

@garrettmflynn garrettmflynn self-assigned this Apr 16, 2024
@rly
Copy link
Collaborator

rly commented Apr 16, 2024

I can't seem to launch the app from dev. Any ideas?

image
dev server running for the electron renderer process at:

  ➜  Local:   http://127.0.0.1:5173/
  ➜  Network: use --host to expose

start electron app...

2024-04-16 16:22:54.021 Electron[58466:1244591] WARNING: Secure coding is not enabled for restorable state! Enable secure coding by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning YES.
Killing all previous processes
Traceback (most recent call last):
  File "/Users/rly/Documents/NWB/nwb-guide/pyflask/app.py", line 20, in <module>

    from flask import Flask, request, send_from_directory, send_file
ModuleNotFoundError: No module named 'flask'

(node:58466) UnhandledPromiseRejectionWarning: undefined
(Use `Electron --trace-warnings ...` to show where the warning was created)
(node:58466) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

@rly
Copy link
Collaborator

rly commented Apr 16, 2024

Oh! My bad. Wrong conda environment! -.-

@rly
Copy link
Collaborator

rly commented Apr 16, 2024

Screenshot 2024-04-16 at 4 27 23 PM

The red error message popup disappears after about 18 seconds. That feels long. The error message popup on the subject ID / session ID page disappears after about 6 seconds. That feels better. Can we change it to disappear after less time?

Even better, could we make the popup disappear after the error has been resolved in the immediate form validation? That is minor and should probably be a separate PR

@garrettmflynn
Copy link
Member Author

Updated both. Thanks for suggesting this!

@rly
Copy link
Collaborator

rly commented Apr 17, 2024

Beautiful! Thank you.

@CodyCBakerPhD CodyCBakerPhD merged commit d44dc15 into main Apr 17, 2024
14 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the defer-name-validation branch April 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Don't make Project Setup > Name red to start
3 participants