-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Backend Configuration #732
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ithoutBorders/nwb-guide into backend-configuration
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ithoutBorders/nwb-guide into backend-configuration
for more information, see https://pre-commit.ci
Are we expecting that the user's choice of backend (i.e. |
How should we handle the below inconsistency between stub and non-stub configurations?
|
Same as everything else - one file per session, let the session manager allow individual file specification, but allow a global default (it would generally be odd to have a mix of backends, but there might be a reason to allow it if there's a special backend-specific compression method they want to use for a data stream that is only available in some subset of sessions - but in general, no reason to force all sessions to be the same) |
Thinking more on it, there isn't much use to apply the backend configuration to a stub file. Neurosift ought to be agnostic to such things aside from slight performance gains |
Some stylistic requests from the first pass through (which felt pretty good once I got it working BTW) a) Should probably suppress the 'Zarr' backend option for the time being (but perhaps leave commented so easy to re enable in future) Reasons include
I know that leaves a dropdown with only a single element, though, so if you'd rather remove the dropdown altogether that might also be OK (and just hardcode 'hdf5' in the payload for now) b) When displaying summary information about the source array, such as I think it would look better to separate the axis lengths by a space and an This is how HDFView does it as well Also, on that same summary, can you use the human readable auto sizing on the source array size (so that one would be on MB scale)? c) Possibly a bug though not sure on what level; if I do as the description says and leave the compression method blank, it still defaults to GZIP (also if I navigate back to this page after proceeding) so I was unable to disable compression |
All of these should be fixed! Just as context for the |
…ation-uniform Uniform Conversion with Backend Configuration
Yeah, it's one of those things... gzip is definitely the initial value that should fill into all the options 'by default', but blank is allowed to equivocate to the Python side of Though I guess it might be even better to add an explicit option in the dropdown for 'No compression' - would you be able to inject that to the schema and map it to mean |
There's no inconsistency as far as I've seen, so the described behavior is what's happening now. I can do this if you'd like, but not 100% sure what the time estimate would be on it—so we might be better off with it as a follow-up. |
Sure, a follow-up for 'no compression' if we have time later But for now you have a way to auto-populate gzip but have 'default' (if I remove text then click off) set to blank? |
Yeah that's just what happens since there isn't a default or global value. |
for more information, see https://pre-commit.ci
…ithoutBorders/nwb-guide into backend-configuration
for more information, see https://pre-commit.ci
src/electron/frontend/core/components/pages/guided-mode/setup/Preform.js
Outdated
Show resolved
Hide resolved
Looks great! |
This PR attempts to show the backend configuration options for a single output NWB file.
Currently running into issues with the SpikeGLX-Phy test pipeline, where the following error is thrown when using an adjusted NeuroConv branch.