-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Session Tests and Tutorial #709
Conversation
Noticed this changelog includes 'new' figures for the single session case, and that was something I wondered about I imagine that is simply triggered via locally running the e2e tests (with screenshot capture enabled? Is that something that can be disabled?) and adding+committing resulting 'new' screenshot files? I do appreciate that GitHub now has sensible image comparison previews, and the files themselves aren't even remotely large, so I'm generally OK with it, just wondering |
Co-authored-by: Cody Baker <[email protected]>
…ithoutBorders/nwb-guide into multisession-tutorial
Yeah those updates are all simply a result of re-running the entire test suite—as I am deleting the entire I can set a couple of flags to determine how many of the images to delete + regenerate, so we aren't dealing with a whole slew of unrelated changes for each tutorial update. |
Otherwise I just manually selected the screenshots that I expected to change and/or had relevant updates using the GitHub Desktop commit manager. Maybe this is the way to do this with the most flexibility? |
As long as it doesn't happen automatically on runs, or we're cognisant to stash them instead of committing each time, this should work fine The hope is that each of those snapshots has a direct analog in the storybook, and that any time a PR induces changes that must be accepted via Chromatic, we'd also bump the snapshots for the tutorial |
Just a few last minute touchups then this is good to go! Looking really good |
@garrettmflynn Dang, merging #712 first seems to have caused a number of failures here |
Co-authored-by: Cody Baker <[email protected]>
for more information, see https://pre-commit.ci
…ithoutBorders/nwb-guide into multisession-tutorial
for more information, see https://pre-commit.ci
This PR extends #708 to run multi-session tests and use the generated screenshots in a Multi-Session Tutorial in the Read the Docs.