Validate C Elegans Sex Correctly #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
The invalidation message is incorrect in this case, see what it should be in the Inspector: https://github.com/NeurodataWithoutBorders/nwbinspector/blob/dev/src/nwbinspector/checks/nwbfile_metadata.py#L211 Also why is what I have selected there invalid? |
|
Ah I see. Works one way (Sex then Species) but not the other. |
|
Should be fixed now! |
for more information, see https://pre-commit.ci
CodyCBakerPhD
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to validate C Elegans sex correctly by grouping the
sexandspeciesproperties on the Subjects table to validate with each other.They now both validate when one changes.
As far as I can tell, Handsontable doesn't allow for different dropdown configurations to be used per-cell—only per-column—so all options have to be shown all the time.