-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspect progress bars with a global handler #695
Conversation
for more information, see https://pre-commit.ci
In general looks much simpler for the GUIDE side, and I like the abstraction Some comments on the other repo about final refinement |
@garrettmflynn This has been replaced by another, right? |
This feature is implemented without this PR. Though this particular addition has not been replaced. We are currently using a GUIDE-internal The intention of this PR was to move more responsibilities to |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…urodataWithoutBorders/nwb-guide into inspect-progress-bars-handler
This appears to break the parallel bars; I'm unsure if it's parallelizing without informing, but I no longer see the sub-progress bars completing per file over a directory |
Good catch, thank you. There was still a leftover |
This PR implements what was discussed in catalystneuro/tqdm_publisher#46 where the
MessageAnnouncer
class used by the GUIDE is superceded by a queue manager provided bytqdm_publisher
.This update allows utilities that ingest the handler (e.g. NWB Inspector, DANDI, etc.) to simple expect a dictionary of
additional_metadata
to pass alongside the update provided byTQDMProgressSubscriber
.Uses catalystneuro/tqdm_publisher#49