Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying subject and session IDs for single-session case #691

Merged
merged 16 commits into from
Mar 23, 2024

Conversation

garrettmflynn
Copy link
Member

fix #689

@bendichter
Copy link
Collaborator

image

The error messages are showing up twice for me on page load. I would really rather they don't show up at all until I hit submit.

@bendichter
Copy link
Collaborator

I also get taken to this page, which should not be reachable in single-session mode

image

@garrettmflynn
Copy link
Member Author

Alright this should be good to review now

@bendichter
Copy link
Collaborator

image

Now for some reason it is not letting me specify Age instead of DOB

@garrettmflynn
Copy link
Member Author

Good catch, thanks! DOB and Age use an alternative mechanism to handle requirement status (i.e. conditional requirements), so these properties had to be excluded from the recent changes.

@garrettmflynn
Copy link
Member Author

@bendichter This should be good to go!

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn Failings tests for this PR

@garrettmflynn
Copy link
Member Author

Thanks for the ping. Fixed

@bendichter
Copy link
Collaborator

LGTM!

@CodyCBakerPhD CodyCBakerPhD merged commit 9670400 into main Mar 23, 2024
15 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the allow-singlesession-id-specification branch March 23, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to define subject_id and session_id in single-session mode
3 participants