Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Updating package.lock file through Actions #673

Closed
wants to merge 7 commits into from

Conversation

garrettmflynn
Copy link
Member

An attempt to fix issues when we push an M1 / M2 package.lock file (#598, #597)

@garrettmflynn garrettmflynn self-assigned this Mar 14, 2024
@CodyCBakerPhD
Copy link
Collaborator

CodyCBakerPhD commented Mar 14, 2024

Also

An attempt to fix issues when we push an M1 / M2 package.lock file (#598, #597)

What does this PR have to do with those previous problems? We're not running into a currently problem with building the app in the distributable/releasable sense are we?

The first PR had to do with M1 specifically (our current issue is with non-M1/M2) and the second PR was the conda environment and is unaffected by the npm side

@garrettmflynn
Copy link
Member Author

garrettmflynn commented Mar 14, 2024

Both of those issues had aspects that were / would have been broken before #605, which would be reversed by pushing a compromised package-lock.json from (at least) my M2—which we want to update somehow to test if that fixes the blocked tests we observe now.

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) March 14, 2024 20:37
@CodyCBakerPhD
Copy link
Collaborator

Hah, IDK - even npm install might be running into issues now: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/8287280865/job/22679223021?pr=673

@CodyCBakerPhD CodyCBakerPhD disabled auto-merge March 14, 2024 20:48
@CodyCBakerPhD
Copy link
Collaborator

@CodyCBakerPhD
Copy link
Collaborator

replaced by #678

@CodyCBakerPhD CodyCBakerPhD deleted the update-package-programatically branch March 15, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants