Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spec CLI #662

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Remove spec CLI #662

merged 4 commits into from
Mar 12, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

@rly @garrettmflynn What do you all think of just removing these? We've had to do so much manual modification of the spec file it is much easier IMO to just continue to directly modify it instead of using this hack

@CodyCBakerPhD CodyCBakerPhD self-assigned this Mar 12, 2024
package.json Outdated Show resolved Hide resolved
@rly
Copy link
Collaborator

rly commented Mar 12, 2024

I agree - it would be easier to modify nwb-guide.spec directly

Co-authored-by: Ryan Ly <[email protected]>
Copy link
Member

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine with me. Let's do it.

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) March 12, 2024 20:21
@CodyCBakerPhD CodyCBakerPhD merged commit 3d994b7 into main Mar 12, 2024
15 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the remove_spec_cli branch March 12, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants